Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "No space left on device" in build job #482

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

medmunds
Copy link

@medmunds medmunds commented Oct 11, 2024

  • Add "Maximize Build Space" step to Build job, to prevent System.IO.IOException: No space left on device. (It was already in the Inspect code and Verify plugin jobs.)
  • Also add it to the Test job, assuming that will start running out of space soon too.
  • Also add it to the Release workflow, which runs a build (thanks tsvetilian-ty)
  • Pin jlumbroso/free-disk-space action to particular version SHA for security and to avoid unexpected workflow behavior changes.

- Add "Maximize Build Space" step to Build job, to prevent
  `System.IO.IOException: No space left on device`. (It was
  already in the Inspect code and Verify plugin jobs.)
- Also add it to the Test job, assuming that will start running
  out of space soon too.
- Pin jlumbroso/free-disk-space action to particular version
  to avoid unexpected workflow behavior changes.
@siropkin
Copy link

siropkin commented Nov 4, 2024

I encountered a "No space left on device" error during a build job. I tried a fix, and it worked perfectly! 🎉

@ramonvermeulen
Copy link

I can confirm, applied the same changes to my plugin and it did the job!

@@ -100,6 +107,13 @@ jobs:
runs-on: ubuntu-latest
steps:

# Free GitHub Actions Environment Disk Space
- name: Maximize Build Space
uses: jlumbroso/[email protected]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this reconfiguration works! 🙌

Why do we point to a specific version instead of the jlumbroso/free-disk-space@main ref?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we point to a specific version instead of the jlumbroso/free-disk-space@main ref?

It's generally a good idea to pin actions to avoid unexpected changes. And actually, since this is a third-party action not maintained by JetBrains, it would be best to pin it to a particular SHA to improve security. (jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be is v1.3.1.)

@tsvetilian-ty
Copy link

tsvetilian-ty commented Nov 15, 2024

Don't we need the jlumbroso/free-disk-space before the fetch step in the .github/workflows/release.yml workflow?

@medmunds
Copy link
Author

Don't we need the jlumbroso/free-disk-space before the fetch step in the .github/workflows/release.yml workflow?

Probably yes, since that workflow ends up (re-)running the build task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants