Ignore constraints in signature for now.

JetBrains · Oct 6, 2022 · c888af8 · c888af8
1 parent 497aa09
commit c888af8
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 1 deletion.
diff --git a/...arper.FSharp/src/FSharp.Psi.Intentions/src/Intentions/AddFunctionToSignatureFileAction.fs b/...arper.FSharp/src/FSharp.Psi.Intentions/src/Intentions/AddFunctionToSignatureFileAction.fs
@@ -25,6 +25,13 @@ type AddFunctionToSignatureFileAction(dataProvider: FSharpContextActionDataProvi
     let (|ValFromImpl|_|) (symbol:FSharpSymbol) =
         match symbol with
         | :? FSharpMemberOrFunctionOrValue as valSymbol ->
+            let hasConstraints =
+                valSymbol.GenericParameters
+                |> Seq.exists (fun gp -> not (Seq.isEmpty gp.Constraints))
+
+            // Ignore constraints for now.
+            if hasConstraints then None else
+
             valSymbol.SignatureLocation
             |> Option.bind (fun range -> if range.FileName.EndsWith(".fs") then Some valSymbol else None)
         | _ -> None

diff --git a/...r.FSharp/test/data/features/intentions/addFunctionToSignature/Generic constraints - 01.fs b/...r.FSharp/test/data/features/intentions/addFunctionToSignature/Generic constraints - 01.fs
@@ -0,0 +1,7 @@
+module Test
+
+let memoizeBy{caret} (g: 'a -> 'c) (f: 'a -> 'b) =
+    let cache =
+        System.Collections.Concurrent.ConcurrentDictionary<_, _>(HashIdentity.Structural)
+
+    fun x -> cache.GetOrAdd(Some(g x), lazy (f x)).Force()
diff --git a/...arp/test/data/features/intentions/addFunctionToSignature/Generic constraints - 01.fs.gold b/...arp/test/data/features/intentions/addFunctionToSignature/Generic constraints - 01.fs.gold
@@ -0,0 +1 @@
+NOT AVAILABLE
diff --git a/....FSharp/test/data/features/intentions/addFunctionToSignature/Generic constraints - 01.fsi b/....FSharp/test/data/features/intentions/addFunctionToSignature/Generic constraints - 01.fsi
@@ -0,0 +1 @@
+module Test
diff --git a/...p/test/src/FSharp.Intentions.Tests/src/Intentions/AddFunctionToSignatureFileActionTest.fs b/...p/test/src/FSharp.Intentions.Tests/src/Intentions/AddFunctionToSignatureFileActionTest.fs
@@ -26,4 +26,8 @@ type AddFunctionToSignatureFileActionTest() =
     [<Test>] member x.``Tuple parameter - 02`` () = x.DoNamedTestWithSignature()
     [<Test>] member x.``Attribute in parameter - 01`` () = x.DoNamedTestWithSignature()
     [<Test>] member x.``Attribute in parameter - 02`` () = x.DoNamedTestWithSignature()
-    [<Test>] member x.``Attribute in parameter - 03`` () = x.DoNamedTestWithSignature()
+    [<Test>] member x.``Attribute in parameter - 03`` () = x.DoNamedTestWithSignature()
+    // Ignore generic constraints for now
+
+    // This test requires `when 'c: equality` at the end of the signature.
+    [<Test>] member x.``Generic constraints - 01`` () = x.DoNamedTestWithSignature()