Scaffold: Quality of life improvements for the Scaffold feature #175
Conversation
|
Have been using myself on a project I have, making multiple scaffolds and tested it quite a lot, couldn't find any issues related to the new functionality. |
There was a problem hiding this comment.
Hi @tcortega, thanks for your contribution!
In general, I think it's a great idea to have more validations around Scaffolding functionality. In addition to my review comments from below, let's maybe also introduce the same logic for the "Schemas" tab.
Some of the places that you updated according to new validations are shared between Tables and Schemas tabs, but data persistency is made only for Tables, the same for validation messages.
Does it work for you to implement also a "Schemas" part in the same way?
...m/jetbrains/rider/plugins/efcore/features/dbcontext/scaffold/ScaffoldDbContextDataContext.kt
Outdated
Show resolved
Hide resolved
src/rider/main/kotlin/com/jetbrains/rider/plugins/efcore/cli/api/DbContextCommandFactory.kt
Outdated
Show resolved
Hide resolved
...m/jetbrains/rider/plugins/efcore/features/dbcontext/scaffold/ScaffoldDbContextDataContext.kt
Outdated
Show resolved
Hide resolved
...jetbrains/rider/plugins/efcore/features/dbcontext/scaffold/ScaffoldDbContextDialogWrapper.kt
Outdated
Show resolved
Hide resolved
…rEach Co-authored-by: Andrii Rublov <[email protected]>
...m/jetbrains/rider/plugins/efcore/features/dbcontext/scaffold/ScaffoldDbContextDataContext.kt
Outdated
Show resolved
Hide resolved
...m/jetbrains/rider/plugins/efcore/features/dbcontext/scaffold/ScaffoldDbContextDataContext.kt
Outdated
Show resolved
Hide resolved
…alling .add and .remove
...jetbrains/rider/plugins/efcore/features/dbcontext/scaffold/ScaffoldDbContextDialogWrapper.kt
Outdated
Show resolved
Hide resolved
My pleasure! Thanks for the plugin :D |
This PR tackles some issues from #172 by storing tables in the project settings and adding table validations. It also prevents empty row errors in the scaffold command.
Had to use
tablesList.value = listOf()inScaffoldDbContextDataContextto reset the list due to the UI state reloading often. TriedtablesList.removeAll(), but it stopped the tab from opening.