-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): add details to custom error #1977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was quick!
client/src/www/app/outline_server_repository/access_key_serialization.ts
Outdated
Show resolved
Hide resolved
…ization.ts Co-authored-by: Vinicius Fortuna <[email protected]>
client/src/www/app/outline_server_repository/access_key_serialization.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Sander Bruens <[email protected]>
super(message); | ||
|
||
this.details = details; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can directly declare details
in the constructor
(like constructor(message: string, private readonly details?: string)
, so we don't need this assignment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I find that particular shortcut confusing, but I can use it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks! That's not a big issue though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
We should post on Reddit and update the doc once it’s released
This will allow providers to send: