Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add eslint import order plugin #1990

Merged
merged 4 commits into from
Apr 23, 2024
Merged

chore: add eslint import order plugin #1990

merged 4 commits into from
Apr 23, 2024

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Apr 22, 2024

No description provided.

@sbruens sbruens requested a review from a team as a code owner April 22, 2024 21:06
@daniellacosse
Copy link
Contributor

Love this plugin!

@sbruens sbruens mentioned this pull request Apr 22, 2024
Merged
@daniellacosse
Copy link
Contributor

If you wanted to go even further at some point, there's dependency cruiser which we could use to enforce certain import patterns.

daniellacosse
daniellacosse approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@daniellacosse daniellacosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once you get it working!

client/src/www/views/contact_view/index.ts Outdated Show resolved Hide resolved
@sbruens sbruens merged commit 983c630 into master Apr 23, 2024
19 checks passed
@sbruens sbruens deleted the sbruens/import-order branch April 23, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellacosse daniellacosse daniellacosse approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbruens @daniellacosse