feat(client/electron): propagate structured errors from Go to TypeScript #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortuna
reviewed
Jun 18, 2024
| @@ -47,6 +47,7 @@ const DNS_RESOLVERS = ['1.1.1.1', '9.9.9.9']; | |||
| // about the others. | |||
| export class GoVpnTunnel implements VpnTunnel { | |||
| private readonly tun2socks: GoTun2socks; | |||
| private readonly connectivityChecker: GoTun2socks; | |||
There was a problem hiding this comment.
Why is this type GoTun2socks? Why do we need two?
There was a problem hiding this comment.
Because we are invoking the same binary with different arguments. And these two processes might run at the same time. For example, we will check connectivity here, and tun2socks is still running until we stop it later.
sbruens
approved these changes
Jun 24, 2024
| } | ||
| return nil | ||
| } | ||
|
|
||
| // newIllegalConfigErrorWithDetails creates a TypeScript parsable SSIllegalConfig error with detailed information. |
There was a problem hiding this comment.
Should this be IllegalConfig?
This was referenced Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added detailed error propagation from Golang to TypeScript for the desktop Outline Client (Windows & Linux).
New Error Details
Empty hostname
Port out-of-range
Current Version (v1.13.1)
Empty hostname
Port out-of-range
