Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(readability): update instructions for setting up firewall rule … #2048

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leulad
Copy link

@leulad leulad commented Jul 7, 2024

Update instructions for setting up firewall rules on AWS #1858
for better readability for wider user base.

@leulad leulad requested a review from a team as a code owner July 7, 2024 16:23
@fortuna fortuna requested a review from sbruens July 8, 2024 14:31
Copy link
Contributor

@sbruens sbruens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution @leulad! We really appreciate contributions from the community.

Unfortunately, this won't be enough to update the instructions. Here are 2 steps you need to take:

  1. The source needs to be changed to add the extra 6th item:
    <li>[[localize('aws-lightsail-firewall-5')]]</li>
  2. The source of message translations is not in en.json but in master_messages.json:
    "aws_lightsail_firewall_5": {
    . You'll need to update this master messages file to ensure we can translate the message to all languages.

Let me know if you run into issues amending your PR. Please also add a screenshot to your PR of what it looks like with your changes so we can take a look to verify. Were you able to run the manager locally following the README instructions to see what your change looks like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants