Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add license check to ensure we only depend on 'notice' licenses #2059

Merged
merged 11 commits into from
Aug 12, 2024

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Jul 23, 2024

No description provided.

@sbruens sbruens requested a review from a team as a code owner July 23, 2024 15:18
@daniellacosse
Copy link
Contributor

You might need to run go mod tidy or something in the check?

@sbruens
Copy link
Contributor Author

sbruens commented Jul 23, 2024

You might need to run go mod tidy or something in the check?

I put it in the wrong place and moved it to the Go test where it will properly setup Go. PTAL.

@sbruens
Copy link
Contributor Author

sbruens commented Aug 9, 2024

Added a license header check for missing license headers. PTAL.

.github/workflows/license.yml Outdated Show resolved Hide resolved
.github/workflows/license.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@daniellacosse daniellacosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a check for our NPM dependencies??

@sbruens
Copy link
Contributor Author

sbruens commented Aug 12, 2024

Do we need a check for our NPM dependencies??

Yes I think we should look into that.

@sbruens sbruens merged commit a37fe2c into master Aug 12, 2024
22 checks passed
@sbruens sbruens deleted the sbruens/licenses branch August 12, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants