refactor(client): move client/go output into root #2109
Conversation
| unpackedAppPath(), 'client', 'output', 'build', | ||
| (isWindows ? 'windows' : 'linux'), | ||
| 'tun2socks' + (isWindows ? '.exe' : '')); | ||
| unpackedAppPath(), |
There was a problem hiding this comment.
@jyyi1 do you know if this will work? do you mind testing it?
There was a problem hiding this comment.
We should all be able to validate the builds. This is an example where the tun-only mode would help. It's one of our biggest pain points. We need to prioritize that.
| unpackedAppPath(), 'client', 'output', 'build', | ||
| (isWindows ? 'windows' : 'linux'), | ||
| 'tun2socks' + (isWindows ? '.exe' : '')); | ||
| unpackedAppPath(), |
There was a problem hiding this comment.
We should all be able to validate the builds. This is an example where the tun-only mode would help. It's one of our biggest pain points. We need to prioritize that.
There was a problem hiding this comment.
Linux is not working (tun2socks is not included in the app, and output folder is not in app.asar.unpacked either, you can easily check the content in this folder after build: > outline-apps/output/client/electron/build/linux-unpacked/resources/app.asar.unpacked):
code: 'ENOENT',
syscall: 'spawn /tmp/.mount_OutlinWCuipE/resources/app.asar.unpacked/output/build/client/linux/tun2socks',
Neither do Windows:
code: 'ENOENT',
syscall: 'spawn C:\\Program Files (x86)\\outline-client\\resources\\app.asar.unpacked\\output\\build\\client\\windows\\tun2socks.exe',
hopefully this won't conflict with your work @fortuna
this basically moves the Tun2socks build result out of cilent/output and into the root output folder