-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(client): normalize config #2203
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
||
it('parses new format', () => { | ||
expect( | ||
config.newTunnelJson({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how shadowsocks looks like.
it('parses abbreviated endpoint', () => { | ||
expect( | ||
config.newTunnelJson({ | ||
transport: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how it looks like with an abbreviated endpoint.
it('parses multi-hop', () => { | ||
expect( | ||
config.newTunnelJson({ | ||
transport: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the nested format. We can use it for Websockets.
it('parses pipe', () => { | ||
expect( | ||
config.newTunnelJson({ | ||
transport: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the pipe format, similar to the SDK format, but in JSON. It simplified the nesting. The idea is that one entry replaces the previous as the "default" dialer.
This is ahead of supporting multiple protocols. Having many ways to represent the same thing is unmanageable.
TODO: