Use Psiphon clientlib #251
Open
+493
−200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
fortuna
requested changes
Jun 18, 2024
| github.com/Psiphon-Labs/quic-go v0.0.0-20240424181006-45545f5e1536 h1:pM5ex1QufkHV8lDR6Tc1Crk1bW5lYZjrFIJGZNBWE9k= | ||
| github.com/Psiphon-Labs/quic-go v0.0.0-20240424181006-45545f5e1536/go.mod h1:2MTiPsgoOqWs3Bo6Xr3ElMBX6zzfjd3YkDFpQJLwHdQ= | ||
| github.com/adam-p/psiphon-tunnel-core v0.0.14-beta-ios.0.20240606165226-007d81eeb28e h1:AADbT95IYlsQ069NMwn1EIRW25QEbKsYB+wjjhqWF28= |
There was a problem hiding this comment.
This shouldn't be here. I think you need go mod tidy.
| @@ -59,184 +61,155 @@ type DialerConfig struct { | |||
| // called before you can start it again with a new configuration. Dialer.Stop should be called | |||
| // when you no longer need the Dialer in order to release resources. | |||
| type Dialer struct { | |||
| // The Psiphon tunnel. It is nil until the tunnel is started. | |||
There was a problem hiding this comment.
There's a lot of state tracking here, and I had a hard time trying to assert the correctness of this code. The mix of Mutex and atomics also complicates analysis.
I believe I got a simpler solution, with the entire tunnel lifecycle in one goroutine.
See #252
Also, for tests, we can replace a global startTunnel. No need to make it part of the Dialer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.