Add react 18 as valid peer dependecy #343
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this in would be great because enabling peer-dependencies is a hacky solution and an anti-pattern. Thanks for making the changes @errnesto |
|
+1, please merge and send it! 🥳 |
|
+1, would really need this! Merge and release please! |
|
+1, it would be great! |
|
Yes please merge 🙏 |
|
When you're waiting for this, I published a package called I've tested for a while in one particular react v18 project using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply adds react18 and react-dom18 as valid peer dependcies so this can be used with a current react version