feat: added reputation method to release #3162

CzarekDryl · 2024-09-24T13:31:25Z

Description

Added reputation method to release step in advanced payment

Testing

Install Reputation Weighted extension
Create advanced payment and go to release step
Choose reputation method from release modal

Main issue: #2256

iamsamgibbs · 2024-10-01T07:08:45Z

@CzarekDryl Can you rebase this so I can give it a review?

CzarekDryl · 2024-10-01T08:07:02Z

@iamsamgibbs Branch rebased

jakubcolony

Thanks for your PR @CzarekDryl, nice to see this coming together.

The message ID for Reputation in the release modal seems incorrect and causing errors:

After releasing via a motion, the UI says it was the Payment creator decision method:

The rest of the flow looks good, including voting and failed motions, nice work 👍

CzarekDryl · 2024-10-02T11:25:32Z

@jakubcolony Payment creator box is not displaying anymore

And translation is added

arrenv

@CzarekDryl Thank you for adding this in. I picked up

The text is wrong in the info callout, it should be "for releasing the payment."
Is there a way to not have the "Failed" show here before the "Passed"? Can we use the skeleton loader?

failed-shows.webm

CzarekDryl · 2024-10-16T10:33:37Z

@arrenv

Description changed to for releasing the payment.
We have the values from the beginning, only over time the value of yayVotes changes. The loading of the action is set to false in this case.

{
    "nayStakes": "4426661121689491626",
    "requiredStake": "4426661121689491626",
    "yayStakes": "4426661121689491626",
    "yayVotes": "0",
    "nayVotes": "0"
}

before

{
    "nayStakes": "4426661121689491626",
    "requiredStake": "4426661121689491626",
    "yayStakes": "4426661121689491626",
    "yayVotes": "398798442899037963861",
    "nayVotes": "0"
}

after

arrenv · 2024-10-16T13:44:05Z

We have the values from the beginning, only over time the value of yayVotes changes. The loading of the action is set to false in this case.

{
    "nayStakes": "4426661121689491626",
    "requiredStake": "4426661121689491626",
    "yayStakes": "4426661121689491626",
    "yayVotes": "0",
    "nayVotes": "0"
}

before

{
    "nayStakes": "4426661121689491626",
    "requiredStake": "4426661121689491626",
    "yayStakes": "4426661121689491626",
    "yayVotes": "398798442899037963861",
    "nayVotes": "0"
}

after

@CzarekDryl does this need to be an arbitrary setTimeout then, maybe like 3 seconds? That way, it allows time for the loading without showing a false outcome, but will still fallback to the hopefully rare occasions where a motion that gets to a vote does not receive any votes.

jakubcolony

Thanks for the rebase @CzarekDryl, I appreciate this must've not been the easiest one due to the amount of changes.

It looks like there's an unfortunate name clash between the concepts of releasing a payment (finalizing expenditure on the contracts) and releasing a milestone (or stage on the contracts) in case of staged payments. I'd like to suggest we go with the contracts naming as they allow for distinction, would be great if you could rename functions and components to reflect that.

That caused some unexpected UI behaviour:

Timer shown in two places for staged payments:

There's a useEffect in PaymentBuilderWidget responsible for setting initially selected funding and release (milestone) actions. It's conflicting with the finalizing actions and there isn't one selected by default:

The action under Payment step matches the action from Release step, which in this case was a motion ready to claim:

jakubcolony · 2024-10-17T17:10:15Z

...ts/v5/common/CompletedAction/partials/PaymentBuilder/partials/PaymentBuilderWidget/hooks.tsx

+  const sortedReleaseActions = useMemo(
+    () =>
+      finalizingActions?.items.filter(notNull).sort((a, b) => {
+        if (a?.createdAt && b?.createdAt) {
+          return Date.parse(b.createdAt) - Date.parse(a.createdAt);
+        }
+        return 0;
+      }) ?? [],
+    [finalizingActions?.items],
+  );


You could reuse an existing sortActionsByCreatedDate util

jakubcolony · 2024-10-17T17:25:11Z

src/context/PaymentBuilderContext/PaymentBuilderContext.ts

+  selectedReleaseAction: ExpenditureAction | null;
+  setSelectedReleaseAction: (action: ExpenditureAction | null) => void;


This has to be separate from release milestone action

jakubcolony · 2024-10-17T17:40:17Z

src/i18n/en.json

+    "releaseModal.permissionsDescription": "This will use your Payer permissions to immediately make the decision and release the payment.",
+    "releaseModal.reputationDescription": "This will start the lazy consensus process using reputation to make the decision for releasing the payment.",


The footer in the modal should show the current user's role instead of hardcoded one

jakubcolony · 2024-10-17T17:42:49Z

.../common/CompletedAction/partials/PaymentBuilder/partials/ReleaseRequests/ReleaseRequests.tsx

@@ -0,0 +1,37 @@
+import React, { type FC } from 'react';


Could you make this (and ReleaseRequestItem) shared components that would also replace ReleaseActions and FundingRequests? They're effectively the same:

I've added new shared component and changed FundingRequests and FinalizeRequests but left it in ReleaseActions because there is some additional logic there

jakubcolony · 2024-10-17T17:50:31Z

...ts/v5/common/CompletedAction/partials/PaymentBuilder/partials/PaymentBuilderWidget/hooks.tsx

+  useEffect(() => {
+    if (!selectedReleaseAction && sortedReleaseActions.length > 0) {
+      setSelectedReleaseAction(sortedReleaseActions[0]);
+    }
+
+    if (
+      selectedReleaseAction &&
+      !sortedReleaseActions.some(
+        (releaseAction) =>
+          releaseAction.transactionHash ===
+          selectedReleaseAction.transactionHash,
+      )
+    ) {
+      setSelectedReleaseAction(null);
+    }
+  }, [selectedReleaseAction, setSelectedReleaseAction, sortedReleaseActions]);


This useEffect needs to work with a similar one in PaymentBuilderWidget

jakubcolony · 2024-10-17T17:56:02Z

...ts/v5/common/CompletedAction/partials/PaymentBuilder/partials/PaymentBuilderWidget/hooks.tsx

+  useEffect(() => {
+    if (
+      !isAnyReleaseMotionInProgress &&
+      allReleaseMotions &&
+      allReleaseMotions.length > 0 &&
+      !allReleaseMotions[0].motionStateHistory.hasPassed
+    ) {
+      setExpectedStepKey(ExpenditureStep.Release);
+    }
+  }, [allReleaseMotions, isAnyReleaseMotionInProgress, setExpectedStepKey]);


What is this responsible for? Seems like the only thing impacted by this would be the funding button which won't be shown at this stage either way.

It seems to me that I handled some case, but without it, everything also seems to work well

jakubcolony · 2024-10-17T19:23:08Z

@arrenv the explanation from @CzarekDryl made me think this must be a race condition that also affects regular motions (as it's using the same code). After 3 attempts I managed to reproduce it on a mint tokens motion:

Screen.Recording.2024-10-17.at.19.18.06.mov

Additionally the voting step shows the wrong outcome:

I have opened an issue #3390.

fix: rebase

CzarekDryl self-assigned this Sep 24, 2024

CzarekDryl requested review from a team as code owners September 24, 2024 13:31

jakubcolony force-pushed the feat/advanced-payments branch from 417daf8 to 1bd4b28 Compare September 26, 2024 09:31

CzarekDryl force-pushed the feat/15886092-release-step-motion branch from 890ca7c to 0324712 Compare October 1, 2024 08:05

jakubcolony requested changes Oct 1, 2024

View reviewed changes

CzarekDryl requested a review from jakubcolony October 2, 2024 11:25

jakubcolony force-pushed the feat/advanced-payments branch 3 times, most recently from d78ac13 to b0d4b0a Compare October 6, 2024 21:53

CzarekDryl force-pushed the feat/15886092-release-step-motion branch from 72668b1 to 0558341 Compare October 7, 2024 13:58

Base automatically changed from feat/advanced-payments to master October 7, 2024 17:43

arrenv requested changes Oct 10, 2024

View reviewed changes

CzarekDryl force-pushed the feat/15886092-release-step-motion branch from 0558341 to bfa399e Compare October 16, 2024 07:23

jakubcolony requested changes Oct 17, 2024

View reviewed changes

jakubcolony mentioned this pull request Oct 17, 2024

Failed pill can sometimes show despite the motion voting positive outcome #3390

Open

feat: added reputation method to release

4d724d4

fix: rebase

CzarekDryl force-pushed the feat/15886092-release-step-motion branch from 3d6c533 to 4d724d4 Compare October 24, 2024 12:31

fix: renamed to finalize, refactor request box

cccf8de

CzarekDryl requested review from arrenv and jakubcolony October 25, 2024 08:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: added reputation method to release #3162

feat: added reputation method to release #3162

CzarekDryl commented Sep 24, 2024

iamsamgibbs commented Oct 1, 2024

CzarekDryl commented Oct 1, 2024

jakubcolony left a comment •

edited

Loading

CzarekDryl commented Oct 2, 2024

arrenv left a comment

CzarekDryl commented Oct 16, 2024 •

edited

Loading

arrenv commented Oct 16, 2024

jakubcolony left a comment

jakubcolony Oct 17, 2024

jakubcolony Oct 17, 2024

jakubcolony Oct 17, 2024

jakubcolony Oct 17, 2024

CzarekDryl Oct 25, 2024

jakubcolony Oct 17, 2024

jakubcolony Oct 17, 2024

CzarekDryl Oct 25, 2024

jakubcolony commented Oct 17, 2024

		selectedReleaseAction: ExpenditureAction \| null;
		setSelectedReleaseAction: (action: ExpenditureAction \| null) => void;

		"releaseModal.permissionsDescription": "This will use your Payer permissions to immediately make the decision and release the payment.",
		"releaseModal.reputationDescription": "This will start the lazy consensus process using reputation to make the decision for releasing the payment.",

feat: added reputation method to release #3162

Are you sure you want to change the base?

feat: added reputation method to release #3162

Conversation

CzarekDryl commented Sep 24, 2024

Description

Testing

iamsamgibbs commented Oct 1, 2024

CzarekDryl commented Oct 1, 2024

jakubcolony left a comment • edited Loading

Choose a reason for hiding this comment

CzarekDryl commented Oct 2, 2024

arrenv left a comment

Choose a reason for hiding this comment

CzarekDryl commented Oct 16, 2024 • edited Loading

arrenv commented Oct 16, 2024

jakubcolony left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakubcolony commented Oct 17, 2024

jakubcolony left a comment •

edited

Loading

CzarekDryl commented Oct 16, 2024 •

edited

Loading