Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: split payment table ui #3316

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: split payment table ui #3316

wants to merge 1 commit into from

Conversation

CzarekDryl
Copy link
Contributor

@CzarekDryl CzarekDryl commented Oct 14, 2024

Description

  • Equal distribution method now uses fractions to calculate amount instead of percentages
  • Changed decimals to dots everywhere in payment table
  • Total amounts is not higher then the originally intended value
image

Testing

  • Create a split payment and play with it

Closed PR with comments - #3042

Resolves #3012

@CzarekDryl CzarekDryl self-assigned this Oct 14, 2024
@CzarekDryl CzarekDryl requested review from a team as code owners October 14, 2024 08:01
Base automatically changed from feat/advanced-payments to master October 14, 2024 22:14
Copy link
Collaborator

@jakubcolony jakubcolony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dots instead of commas ✅
image

image

Redoing action ✅
redo-staked-test

I came across a slightly different issue which I'm hoping could be fixed here as well, when manually changing the percentage value (while Equal or Reputation split is selected), entering the first digit causes the field to lose focus. You can't really see that in the recording but I kept pressing 5 and had to refocus the field again:

Screen.Recording.2024-10-21.at.22.38.09.mov

@AdrianDudko
Copy link

hi @jakubcolony

I came across a slightly different issue which I'm hoping could be fixed here as well, when manually changing the percentage value (while Equal or Reputation split is selected), entering the first digit causes the field to lose focus. You can't really see that in the recording but I kept pressing 5 and had to refocus the field again:

Screen.Recording.2024-10-21.at.22.38.09.mov

This PR (along with the closed, original one) is nearly 2 months old and is becoming unwieldy. @CzarekDryl has several large open PRs that would be worth closing. I suggest addressing this in a separate issue. fyi @arrenv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split payment fixes to formatting and rounding
3 participants