fix: change user overview info #3332
Open
+46
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
strzelec seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
rdig
approved these changes
Oct 16, 2024
jakubcolony
requested changes
Oct 22, 2024
There was a problem hiding this comment.
Thanks for your PR @adam-strzelec 👍
Unfortunately, when I voted support as a user who did not stake, I got the failed message despite the motion passing:
| @@ -116,6 +119,7 @@ export const useClaimConfig = ( | |||
| actionData.motionData.motionStateHistory.hasFailedNotFinalizable; | |||
|
|
|||
| const userStake = usersStakes.find(({ address }) => address === userAddress); | |||
| const userVote = voterRecord.some((item) => item.address === userAddress); | |||
There was a problem hiding this comment.
how about hasUserVoted to indicate it's a boolean and not the vote value?
| ? 'motion.finalizeStep.failed.statusText' | ||
| : 'motion.finalizeStep.statusText', | ||
| id: | ||
| isMotionFailedNotFinalizable || (!userStake && userVote) |
There was a problem hiding this comment.
Not sure I'm following this. Why do we want to show failed status text if user did not stake but has voted?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change appearance of action overview card info
Testing
Diffs
New stuff ✨
Display date of complete action
Changes 🏗
Change text inside cards
Resolves #31415