-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change user overview info #3332
base: master
Are you sure you want to change the base?
Conversation
strzelec seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR @adam-strzelec π
Unfortunately, when I voted support as a user who did not stake, I got the failed message despite the motion passing:
@@ -116,6 +119,7 @@ export const useClaimConfig = ( | |||
actionData.motionData.motionStateHistory.hasFailedNotFinalizable; | |||
|
|||
const userStake = usersStakes.find(({ address }) => address === userAddress); | |||
const userVote = voterRecord.some((item) => item.address === userAddress); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about hasUserVoted
to indicate it's a boolean and not the vote value?
? 'motion.finalizeStep.failed.statusText' | ||
: 'motion.finalizeStep.statusText', | ||
id: | ||
isMotionFailedNotFinalizable || (!userStake && userVote) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I'm following this. Why do we want to show failed status text if user did not stake but has voted?
Description
Change appearance of action overview card info
Testing
Diffs
New stuff β¨
Display date of complete action
Changes π
Change text inside cards
Resolves #31415