Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/16099336 table filters #3379

Open
wants to merge 12 commits into
base: feat/16099337-payments-table
Choose a base branch
from

Conversation

CzarekDryl
Copy link
Contributor

@CzarekDryl CzarekDryl commented Oct 17, 2024

Description

  • Added buttons for filtering and searching streaming payments table
  • Added pagination to table
  • Added empty state
  • Sort by active was removed by Arren
image

Testing

  • Create multiple streaming payments
  • Navigate to /{colony}/streaming-payments page

Main issue - #3260

@CzarekDryl CzarekDryl self-assigned this Oct 17, 2024
@CzarekDryl
Copy link
Contributor Author

CzarekDryl commented Oct 17, 2024

@arrenv Currently filtering by token, status, end condition and sorting by status and streamed amount is not available on backend. Should we handle this on frontend?
@AdrianDudko fyi

@CzarekDryl CzarekDryl marked this pull request as ready for review October 21, 2024 12:29
@CzarekDryl CzarekDryl requested review from a team as code owners October 21, 2024 12:29
Copy link
Member

@arrenv arrenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CzarekDryl Thank you for the PR, I noticed a few things while testing.

  1. The filters or data in the tables do not seem accurate. Only one in the list should not be started, but all 4 are showing under the active filter, despite there being 3 showing as Not started.
    image

  2. The End condition also does not seem to be accurate. Only one of this is a Fixed date, for example.
    image

  3. The End condition filter does not seem to allow you to remove the filter when clicking to remove it.
    image

  4. Filtering by token type and selecting ETH then CREDS crashed the app:
    image

  5. Filtering by date does not seem easy to test in local, but, I am getting this error in the console:
    image

  6. I had trouble get the date range to work, as it would not accept clicking dates, without clicking apply, but the apply button always hidden under the screen. Can this auto fill the date fields when clicking on them and the modal closes.
    date-filter-stream.webm

@CzarekDryl
Copy link
Contributor Author

@arrenv Everything should work fine now, please take a look at this again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants