-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/16099336 table filters #3379
base: feat/16099337-payments-table
Are you sure you want to change the base?
Feat/16099336 table filters #3379
Conversation
@arrenv Currently filtering by token, status, end condition and sorting by status and streamed amount is not available on backend. Should we handle this on frontend? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CzarekDryl Thank you for the PR, I noticed a few things while testing.
-
The filters or data in the tables do not seem accurate. Only one in the list should not be started, but all 4 are showing under the active filter, despite there being 3 showing as Not started.
-
The End condition also does not seem to be accurate. Only one of this is a Fixed date, for example.
-
The End condition filter does not seem to allow you to remove the filter when clicking to remove it.
-
Filtering by token type and selecting ETH then CREDS crashed the app:
-
Filtering by date does not seem easy to test in local, but, I am getting this error in the console:
-
I had trouble get the date range to work, as it would not accept clicking dates, without clicking apply, but the apply button always hidden under the screen. Can this auto fill the date fields when clicking on them and the modal closes.
date-filter-stream.webm
@arrenv Everything should work fine now, please take a look at this again :) |
Description
Testing
/{colony}/streaming-payments
pageMain issue - #3260