feat add invitation banner for landing page #3431
Conversation
|
strzelec seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
What a nice component @adam-strzelec 🙌
Design wise seem to be looking as expected
Left a veeeery tiny refactoring comment 😁
But nice job 🎉
| <p className="mt-2 text-sm font-normal"> | ||
| {formatText({ | ||
| id: | ||
| coloniesRemaining > 0 |
There was a problem hiding this comment.
Let's refactor this into a constant const hasColoniesRemaining = coloniesRemaining > 0 and use it here
| : 'landingPage.invitationBanner.descriptionNoRemaining', | ||
| })} | ||
| </p> | ||
| {coloniesRemaining > 0 && ( |
There was a problem hiding this comment.
Let's use hasColoniesRemaining also here
There was a problem hiding this comment.
Sorry @adam-strzelec on a second look I found some small mismatches with Figma
| return ( | ||
| <div className="w-full max-w-[31.25rem] rounded-2xl border px-6 py-6"> | ||
| <div className="flex h-10 w-10 items-center justify-center rounded-md border"> | ||
| <SmileySticker size={20} /> |
There was a problem hiding this comment.
Actually on a second look, I think this should be 24
| <div className="flex h-10 w-10 items-center justify-center rounded-md border"> | ||
| <SmileySticker size={20} /> | ||
| </div> | ||
| <h1 className="mb-[.625rem] mt-[.625rem] heading-4"> |
| )} | ||
| </span> | ||
|
|
||
| <p className="mt-2 text-sm font-normal"> |
There was a problem hiding this comment.
And I think we should also apply text-gray-700
Description
Add colony invitation banner for landing page
Testing
Colony Invitation BannerDiffs
New stuff ✨
Main issue - #3392