[Notifications] Fix: Notifications should use correct amount #3443
+6
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applies the fix introduced in #3307 for the amount in the activity feed and applies it to the notification messages.
Due to the way notification messages are structured, it is very unlikely this would ever actually show up in production as it priorities the custom title, so would only ever show if a custom title was not provided (which is not possible via the UI). However it is such a tiny fix that we will apply it regardless!
Testing
src/components/common/Extensions/UserHub/partials/NotificationsTab/partials/Notification/Action/MotionNotificationMessage.tsx
and remove actionTitle from thesecondPart
variable.Should become:
This will ensure the custom title is not shown.
npm run forward-time 1
and finalise the motion.Diffs
Changes 🏗
networkInverseFee
is passed toactionMetadataDescription
for notifications