[Notifications] Fix: Notifications should use correct amount

[iamsamgibbs]

Description

This PR applies the fix introduced in #3307 for the amount in the activity feed and applies it to the notification messages.

Due to the way notification messages are structured, it is very unlikely this would ever actually show up in production as it priorities the custom title, so would only ever show if a custom title was not provided (which is not possible via the UI). However it is such a tiny fix that we will apply it regardless!

Testing

• Step 1 - Go to src/components/common/Extensions/UserHub/partials/NotificationsTab/partials/Notification/Action/MotionNotificationMessage.tsx and remove actionTitle from the secondPart variable.

const secondPart =
      actionTitle || actionMetadataDescription || formatText(MSG.unknownAction);

Should become:

    const secondPart =
      actionMetadataDescription || formatText(MSG.unknownAction);

This will ensure the custom title is not shown.

• Step 2 - Install the reputation weighted voting extension
• Step 3 - Create a simple payment motion
• Step 4 - Stake to support it fully
• Step 5 - Check the notification, note the amount should exactly match the amount entered when creating the motion.

• Step 6 - Run the following mutation in GraphiQL to change the network fee stored in the database:

mutation MyMutation {
  updateCurrentNetworkInverseFee(
    input: {id: "networkInverseFee", inverseFee: "50"}
  ) {
    id
    inverseFee
  }
}

• Step 7 - Refresh and check the notification again. The amount should have changed to reflect the change in network fee.

• Step 8 - Forward time with npm run forward-time 1 and finalise the motion.

• Step 9 - Run another mutation to change the network fee back.

mutation MyMutation {
  updateCurrentNetworkInverseFee(
    input: {id: "networkInverseFee", inverseFee: "100"}
  ) {
    id
    inverseFee
  }
}

• Step 10 - Refresh and check the notification. The amount change not have changed as the network fee changed after the motion was finalized.

Diffs

Changes 🏗

• networkInverseFee is passed to actionMetadataDescription for notifications

[mmioana]

Thanks for keeping an eye on this @iamsamgibbs and nice work 👏 🙌

Everything works as expected ✨

Applied the code change to not display the custom action title

Installed the extension

Created a simple payment with Reputation

Updated the network fee

And the notifications have updated the displayed amount

Finalised the motion

Reverted the change to the network fee

And the values remained as before 💪

Niiice 🎉

[rdig]

Tested this and all good, up until the motion finishes, the value correctly changes based on the network fee.

Once finalized, it's no longer affected by fee changes.

Very nice!

One thing I want to point out (as I also mention in the channel), that the landing page navigation sidebar is broken on this branch, but most likely due to a rebase

Screencast.from.2024-10-24.12-44-04.mp4

[davecreaser]

Great stuff @iamsamgibbs thank you so much for keeping track of this and fixing it! 🚀

It works exactly as you've described:

And after running the final mutation the amount hasn't changed. Nice one!

PS. Sorry, but you'll need to rebase again since I had to rebase the notifications branch while fixing that pesky sidepanel navigation issue.