Fix: bridgeXYZMutation to return null on error #3471
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cosmetic-looking change that caused the linked issue when Bridge API went down earlier today. The JSON response got stringified and a payment was attempted to
{ success: false }
.This PR changes the return value of the bridge mutation to
null
if error is thrown.Testing
To test the fix, you will need to simulate an error in
getUserLiquidationAddress
handler, and make a payment that will trigger liquidation address swapping.While you could set your native token address as
USDC_LOCAL_ADDRESS
in.env.local
, go through KYC, add bank details and enable auto offramp, you can also create a file calleddiff
with the contents below and apply the patch withgit apply diff
. It will make liquidation address swapping happen for any token and recipient, and throw an error inside the lambda handler.Next, make a payment (simple or advanced) to
leela
. The payment should go through to her actual wallet address. Onmaster
, you would get the wrong address error as in the issue.Resolves #3456