Add type checking #276
Closed
Add type checking #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shutil.which() was added in Python 3.3 so we no longer need our own version.
JonathonReinhart
force-pushed
the
pre-typing-cleanups
branch
from
36c252d
to
3eea980
Compare
This adds an initial [tool.mypy] section to pyproject.toml which checks modules which have no typing errors. This also adds mypy to requirements.txt for development.
JonathonReinhart
force-pushed
the
add-type-checking
branch
from
76dc29b
to
315cbac
Compare
JonathonReinhart
force-pushed
the
add-type-checking
branch
from
315cbac
to
5674459
Compare
JonathonReinhart
force-pushed
the
add-type-checking
branch
from
5674459
to
c91432c
Compare
|
I'm not sure why actions aren't running. Going to start a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.