Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions & Upgrade to .NET 8 #3

Closed
wants to merge 9 commits into from
Closed

Conversation

JosefDvorak
Copy link
Owner

@JosefDvorak JosefDvorak commented Jan 8, 2024

Motivation

The purpose of this PR is to add a minimum viable replacement for AppVeyor Build test using GitHub Actions Workflow

As part of the implementation, several issues were encountered that had to be addressed:

  • The .NET Core 2.2 compatibility with Actions Workflow
    • Resolved by upgrade to .NET 8
  • Packages with bugs when used in .NET 8
    • Resolved by upgrading:
      • Autofac
      • SqlClient
  • JSON serialization behaviour has changed.
    • Resolved by implementing missing converters.

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

Test that project builds, reports execute and conduct code review.

This is a mirror repository for testing GitHub Action Workflow configuration.

The serialization logic has changed in .NET 8 and the code needs to implement converters for complex type, such as System.Version.
Add specific Node version to use: 20.7.x

Add front-end build step.

Add manual Workflow dispatch.
@JosefDvorak JosefDvorak changed the title Change Target framework to .NET 8.0 Add GitHub Actions Jan 15, 2024
@JosefDvorak JosefDvorak changed the title Add GitHub Actions Add GitHub Actions & Upgrade to .NET 8 Jan 15, 2024
@JosefDvorak JosefDvorak deleted the DotnetUpdate branch January 16, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants