Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/value changes #1408

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

Fix/value changes #1408

wants to merge 18 commits into from

Conversation

MattKuhn123
Copy link

@MattKuhn123 MattKuhn123 commented Jul 26, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

When a formControl's value is set programmatically with a value that doesn't fit the mask, then the value displayed in the element won't match what the programmer was expecting.

Issue Number: 1372

What is the new behavior?

To help the programmer understand what is going on, detect if there was a fault with the mask application. If a fault was detected, log a warning in the console, and display the programmatically-set value in the element.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

MAttitiyahoo2 and others added 18 commits July 24, 2024 16:12
@MAttitiyahoo2
BugFix (ref: 1372)
e098ca8 
apply the same value to native element as what is applied to the form control when formControl.setValue is called. Log a warning and optionally return a validation error.
@MattKuhn123
Merge branch 'develop' into fix/valueChanges
eaab822
@MattKuhn123
Fix(1372)
ed6cbb7 
removing configurability, because it seems that making something configurable impacts many projects (and not just this one). Can add later, if it's worth the complexity.

updating maskAppliedWithoutIssue to also accomodate dropSpecialCharacters
@MattKuhn123
rm debuggers
267f700
@MattKuhn123
use maskExpression on _maskService. Do not throw special ValidationEr…
42a76ff 
…rors. Do not attempt to interpret !_justPased and !_code as setValueTriggered
@MattKuhn123
accounting for more possibilities in unmasking
075626e
@MattKuhn123
uncomment setValue test
10584db
@MattKuhn123
maskingIssue does not need module-level scope
49a06c6
@MattKuhn123
fault, separator
254abc0
@MattKuhn123
whitespace
f29d6b4
@MattKuhn123
refactor into methods
f4134e3
@MattKuhn123
rename maskAppliedWithoutFault to maskApplicationFault
e27d200
@MattKuhn123
update comments
bf66fef
@MattKuhn123
refactor into its own class
89e5e90
@MattKuhn123
test and provide NgxMaskFaultDetectionService
c82d45c
@MattKuhn123
do not use controlValue
ebca346
@MattKuhn123
only returns string, not boolean.
e50bc3d
@MattKuhn123
update comment for clarity
8bc3a0f
@MattKuhn123 MattKuhn123 marked this pull request as ready for review July 30, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattKuhn123 @MAttitiyahoo2