fix(Android): properly check on pollForValidSSID if network connected #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is required as the network state might be 'connecting' to a network it'd look the same as 'connected' without checking for status
|
which contributors have time to check this? wondering if there's any issues with the implementation cc: @JuanSeBestia |
DavideViolante
force-pushed
the
master
branch
from
cfc0789
to
f516e8d
Compare
|
LGTM, can you fix the conflicts please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pollForValidSSID is checking if network is 'something', which might just be connecting so it fails to actually wait for a proper connection to be realized - tested with
examples/with-expodemo on Android 8