For a 0.1.1 release #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add draft for RFE model * rename package * Add FeatureSelectore and some tests * fix current tests * complete RFE model and add tests * Update model docstring * fix code, Update readme and add more tests * Apply suggestions from code review Co-authored-by: Anthony Blaom, PhD <[email protected]> * rename n_features_to_select to n_features * update readme with * Apply suggestions from code review Co-authored-by: Anthony Blaom, PhD <[email protected]> * set max column limit to 92 in readme * add Aqua.jl tests and refactor code * update ci * Apply suggestions from code review Co-authored-by: Anthony Blaom, PhD <[email protected]> * fix bug, add support for serialization and add more tests * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * add documentation * Disable julia Nighly tests --------- Co-authored-by: Anthony Blaom, PhD <[email protected]>
Overload `constructor` for `RecursiveFeatureElimination` types
10 tasks
fix docstring and build documentation - take II
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11 +/- ##
=========================================
Coverage ? 85.61%
=========================================
Files ? 3
Lines ? 146
Branches ? 0
=========================================
Hits ? 125
Misses ? 21
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
I'm merging despite the doc fail, as tracked and I need this release downstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10