Fix handling weights in supervised fit data scitype #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a flaw in the definition of
supervised_fit_data_scitype
which defines the fallbackfit_data_scitype
forSupervised
models. The problem concerned the casesupports_weights(model)=true
orsupports_class_weights(model)=true
.This PR supports JuliaAI/MLJBase.jl#731
cc @pazzo83