Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling weights in supervised fit data scitype #137

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Jan 27, 2022

This PR fixes a flaw in the definition of supervised_fit_data_scitype which defines the fallback fit_data_scitype for Supervised models. The problem concerned the case supports_weights(model)=true or supports_class_weights(model)=true.

This PR supports JuliaAI/MLJBase.jl#731

cc @pazzo83

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022

Codecov Report

Merging #137 (c2b4a66) into dev (2a77b27) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #137   +/-   ##
=======================================
  Coverage   87.29%   87.29%           
=======================================
  Files           8        8           
  Lines         299      299           
=======================================
  Hits          261      261           
  Misses         38       38           
Impacted Files Coverage Δ
src/model_traits.jl 71.69% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a77b27...c2b4a66. Read the comment docs.

@ablaom ablaom merged commit d207f88 into dev Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants