Remove some unused variables #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests appear to fail due to dmlc/XGBoost.jl#191. I've now pinned the |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #42 +/- ##
==========================================
- Coverage 58.26% 57.25% -1.01%
==========================================
Files 1 1
Lines 127 124 -3
==========================================
- Hits 74 71 -3
Misses 53 53
☔ View full report in Codecov by Sentry. |
ablaom
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Looks good to me, thanks @rikhuijzer . I imagine this code predates @ExpandingMan 's major refactor. Obviously it's not doing anything useful now.
Agree, no need for a new release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes some unused variables. No need for triggering a new release, in my opinion. This can be included in the next release whenever that happens.