Remove compat restrictions again #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 57.25% 57.93% +0.67%
==========================================
Files 1 1
Lines 124 126 +2
==========================================
+ Hits 71 73 +2
Misses 53 53 ☔ View full report in Codecov by Sentry. |
rikhuijzer
force-pushed
the
rh/avoid-passing-empty-watchlist
branch
from
86f2f19
to
2112c69
Compare
|
Thanks! Sorry, I forgot about this when I merged in XGBoost.jl. |
rikhuijzer
changed the title
rikhuijzer
force-pushed
the
rh/avoid-passing-empty-watchlist
branch
from
101c090
to
5dc4f74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46 and closes #49. This is PR is a permanent fix after the hotfix in #47.
In hindsight, I should have checked with XGBoost first to let them make a patch. My bad. This PR basically reverts #47.
@ablaom I renamed
otooutbecause that appears to be the intention of that variable. I hope that's okay.