Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move viewer to JavisViewer #461

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Conversation

gpucce
Copy link
Member

@gpucce gpucce commented Jan 22, 2022

PR Checklist

If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

  • Did I update CHANGELOG.md with whatever changes/features I added with this PR?
  • Did I make sure to only change the part of the file where I introduced a new change/feature?
  • Did I cover all corner cases to be close to 100% test coverage (if applicable)?
  • Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
  • Did I properly add test dependencies to the test directory (if applicable)?
  • Did I check relevant tutorials that may be affected by changes in this PR?
  • Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)
Closes #460

How did you address these issues with this PR? What methods did you use?
In this PR I remove all parts of Javis that are used for the liveview and will add them in the JavisViewer.jl package.

Once I create a PR in JavisViewer I will reference this one.

@gpucce gpucce marked this pull request as draft January 22, 2022 11:46
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2022

Codecov Report

Merging #461 (0df92a1) into main (0f24fcd) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
- Coverage   96.47%   96.42%   -0.05%     
==========================================
  Files          35       35              
  Lines        1617     1568      -49     
==========================================
- Hits         1560     1512      -48     
+ Misses         57       56       -1     
Impacted Files Coverage Δ
src/Javis.jl 97.30% <0.00%> (+0.43%) ⬆️
src/javis_viewer.jl 84.37% <ø> (-8.13%) ⬇️
src/morphs.jl 95.97% <0.00%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f24fcd...0df92a1. Read the comment docs.

@gpucce
Copy link
Member Author

gpucce commented Jan 22, 2022

@Wikunia @TheCedarPrince And with a new PR a new interface question.

I am going similar to JavisNB with the equivalent of embed being stream the question is I am moving the liveview=true option into stream and entirely out of render, or at least that would be the plan. Is this a good idea or do you prefer the possibility to call liveview from render itself? Perhaps the best is having it in both render and stream acting in the same way?

Let me know what you think!

@Wikunia
Copy link
Member

Wikunia commented Jan 22, 2022

I think I would use a liveview function which works similar to the embed function. No need for a liveviewer keyword anymore. Stream sounds more reasonable to me when we have a stream to twitch functionality or something like that.

@Wikunia Wikunia changed the base branch from master to main February 25, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move liveview outside Javis
3 participants