-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move viewer to JavisViewer #461
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #461 +/- ##
==========================================
- Coverage 96.47% 96.42% -0.05%
==========================================
Files 35 35
Lines 1617 1568 -49
==========================================
- Hits 1560 1512 -48
+ Misses 57 56 -1
Continue to review full report at Codecov.
|
@Wikunia @TheCedarPrince And with a new PR a new interface question. I am going similar to Let me know what you think! |
I think I would use a |
…nto gp-move-viewer
…nto gp-move-viewer
PR Checklist
If you are contributing to
Javis.jl
, please make sure you are able to check off each item on this list:CHANGELOG.md
with whatever changes/features I added with this PR?Project.toml
+ set an upper bound of the dependency (if applicable)?test
directory (if applicable)?Link to relevant issue(s)
Closes #460
How did you address these issues with this PR? What methods did you use?
In this PR I remove all parts of
Javis
that are used for the liveview and will add them in theJavisViewer.jl
package.Once I create a PR in JavisViewer I will reference this one.