Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of error in Fourier example #468

Merged
merged 4 commits into from
Feb 27, 2022
Merged

Conversation

aburousan
Copy link
Contributor

@aburousan aburousan commented Feb 27, 2022

PR Checklist

Link to relevant issue(s)
https://github.com/JuliaAnimators/Javis.jl/issues/467
Closes #460

How did you address these issues with this PR? What methods did you use?
Updated the file with correct ones.

anim_translate needs two parameters and render's pathname is changed to remove error.
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2022

Codecov Report

Merging #468 (b54a05c) into main (3465eff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #468   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files          35       35           
  Lines        1617     1617           
=======================================
  Hits         1560     1560           
  Misses         57       57           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3465eff...b54a05c. Read the comment docs.

@gpucce gpucce merged commit 19a75d9 into JuliaAnimators:main Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move liveview outside Javis
3 participants