On tags, skip the upload if the files already exist on S3 #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The treehashes need to be re-signed. However, I'll wait to re-sign them until after we've finished reviewing this PR and making any necessary changes. |
DilumAluthge
force-pushed
the
dpa/no-overwrite-s3
branch
from
fc32313
to
598b934
Compare
DilumAluthge
force-pushed
the
dpa/no-overwrite-s3
branch
from
7c197f4
to
4f7dbb0
Compare
|
In theory, we're vulnerable to TOCTOU here. But we only start the |
|
Why are we shy about replacing tagged binaries? We're not uploading directly to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If
${TAR_VERSION}does NOT match the regex^\d*?\., then we always upload.If
${TAR_VERSION}DOES match the regex, then we do a HEAD request to see if the files already exist. If they do exist, we don't upload. If they don't exist, we do upload.Motivation
I'd like to be able to trigger new builds without worrying about overwriting existing tagged binaries on S3.
This is only relevant for tags.