Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DictoVec: derive from AbstractVector #96

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

alyst
Copy link
Collaborator

@alyst alyst commented Aug 9, 2023

Sometimes R data.frame are constructed such that columns have element names.
RData.jl would then convert these columns into DictoVec object.
However, when converting R data.frame into DataFrames.jl DataFrame object, all column containers are required to support AbstractVector interface.
This PR fixes the failure of DataFrame construction by making DictoVec inherited from AbstractVector and adding necessary methods that are used during DataFrame construction.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (159f19e) 86.64% compared to head (8b00563) 86.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   86.64%   86.70%   +0.05%     
==========================================
  Files          14       14              
  Lines         689      692       +3     
==========================================
+ Hits          597      600       +3     
  Misses         92       92              
Files Changed Coverage Δ
src/DictoVec.jl 96.25% <100.00%> (+0.04%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alyst alyst merged commit 071d2f6 into main Aug 9, 2023
17 checks passed
@alyst alyst deleted the ast/dictovec_vec_iface branch August 9, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant