Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DimensionalData dependency to 0.27 #390

Merged
merged 4 commits into from
May 2, 2024
Merged

Bump DimensionalData dependency to 0.27 #390

merged 4 commits into from
May 2, 2024

Conversation

felixcremer
Copy link
Member

This replaces the deprecated DimensionalData functions key2dim and dim2key with their new versions.

The fix seemed to be very smooth but I am not sure whether this is breaking, because it might change the behaviour of the Ti and time axes.

@coveralls
Copy link

coveralls commented Apr 29, 2024

Pull Request Test Coverage Report for Build 8923198631

Details

  • 9 of 22 (40.91%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.231%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Cubes/Slices.jl 0 1 0.0%
src/DAT/registration.jl 0 1 0.0%
src/DAT/DAT.jl 0 2 0.0%
src/DatasetAPI/Datasets.jl 3 5 60.0%
src/Cubes/Cubes.jl 3 6 50.0%
src/DAT/tablestats.jl 2 6 33.33%
Totals Coverage Status
Change from base Build 8786965965: 0.0%
Covered Lines: 1207
Relevant Lines: 1769

💛 - Coveralls

@lazarusA
Copy link
Collaborator

you need to bump also the version of DD for docs.

@felixcremer
Copy link
Member Author

I don't understand why this failed, because the docs/Project.toml does not specify a version for any packages for good reason.
I just restarted the job and hope, that it works.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 40.90909% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 67.34%. Comparing base (a287107) to head (3d6ebc9).
Report is 2 commits behind head on master.

❗ Current head 3d6ebc9 differs from pull request most recent head c6af482. Consider uploading reports for the commit c6af482 to get more accurate results

Files Patch % Lines
src/DAT/tablestats.jl 33.33% 4 Missing ⚠️
src/Cubes/Cubes.jl 50.00% 3 Missing ⚠️
src/DAT/DAT.jl 0.00% 2 Missing ⚠️
src/DatasetAPI/Datasets.jl 60.00% 2 Missing ⚠️
src/Cubes/Slices.jl 0.00% 1 Missing ⚠️
src/DAT/registration.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #390      +/-   ##
==========================================
- Coverage   68.15%   67.34%   -0.81%     
==========================================
  Files          12       12              
  Lines        1771     1770       -1     
==========================================
- Hits         1207     1192      -15     
- Misses        564      578      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixcremer
Copy link
Member Author

I added a line to update the registry into the Documenter workflow and now the docs build successfully. I also updated the codecov action to 0.4 to hopefully fix the codecove issues on Ubuntu

@lazarusA
Copy link
Collaborator

lazarusA commented May 2, 2024

Merge?

@felixcremer felixcremer merged commit b4bf448 into master May 2, 2024
9 of 10 checks passed
@felixcremer felixcremer deleted the fc/dd27 branch May 2, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants