Skip to content

Commit

Permalink
test(LibPQ): run the async result test with both types of connections…
Browse files Browse the repository at this point in the history 
…, and option to run all with any type
  • Loading branch information
@pankgeorg
pankgeorg committed Sep 6, 2023
1 parent 4b6c77c commit 6c7f795
Show file tree
Hide file tree
Showing 2 changed files with 52 additions and 3 deletions.
3 changes: 2 additions & 1 deletion src/asyncresults.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,8 @@ function async_execute(
string_params = string_parameters(parameters)
pointer_params = parameter_pointers(string_params)

async_result = _async_execute(jl_conn; binary_format=binary_format, kwargs...) do jl_conn
async_result =
_async_execute(jl_conn; binary_format=binary_format, kwargs...) do jl_conn
GC.@preserve string_params _async_submit(
jl_conn, query, pointer_params; binary_format=binary_format
)
Expand Down
52 changes: 50 additions & 2 deletions test/runtests.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ function count_allocs(f, args...)
return Base.gc_alloc_count(stats.gcstats)
end

@testset "LibPQ" begin
usenonblocking = get(ENV, "usenonblocking", false)
@testset "LibPQ $(usenonblocking ? "(nonblocking connection)" : "")" begin

Check warning on line 45 in test/runtests.jl

View workflow job for this annotation

GitHub Actions / format 

[JuliaFormatter] reported by reviewdog 🐶


Raw Output:
test/runtests.jl:45:+    @testset "ConninfoDisplay" begin
test/runtests.jl:46:+        @test parse(LibPQ.ConninfoDisplay, "") == LibPQ.Normal
test/runtests.jl:47:+        @test parse(LibPQ.ConninfoDisplay, "*") == LibPQ.Password
test/runtests.jl:48:+        @test parse(LibPQ.ConninfoDisplay, "D") == LibPQ.Debug
test/runtests.jl:49:+        @test_throws LibPQ.Errors.JLConnectionError parse(LibPQ.ConninfoDisplay, "N")
test/runtests.jl:50:+    end
@testset "ConninfoDisplay" begin

Check warning on line 46 in test/runtests.jl

View workflow job for this annotation

GitHub Actions / format 

[JuliaFormatter] reported by reviewdog 🐶


Raw Output:
test/runtests.jl:46:-@testset "ConninfoDisplay" begin
test/runtests.jl:47:-    @test parse(LibPQ.ConninfoDisplay, "") == LibPQ.Normal
test/runtests.jl:48:-    @test parse(LibPQ.ConninfoDisplay, "*") == LibPQ.Password
test/runtests.jl:49:-    @test parse(LibPQ.ConninfoDisplay, "D") == LibPQ.Debug
test/runtests.jl:50:-    @test_throws LibPQ.Errors.JLConnectionError parse(LibPQ.ConninfoDisplay, "N")
test/runtests.jl:51:-end
test/runtests.jl:52:+    @testset "Version Numbers" begin
test/runtests.jl:53:+        valid_versions = [
test/runtests.jl:54:+            (LibPQ.pqv"11", v"11"),
test/runtests.jl:55:+            (LibPQ.pqv"11.80", v"11.0.80"),
test/runtests.jl:56:+            (LibPQ.pqv"10.1", v"10.0.1"),
test/runtests.jl:57:+            (LibPQ.pqv"9.1.5", v"9.1.5"),
test/runtests.jl:58:+            (LibPQ.pqv"9.2", v"9.2.0"),
test/runtests.jl:59:+            (LibPQ.pqv"8", v"8.0.0"),
test/runtests.jl:60:+        ]
test/runtests.jl:61:+
test/runtests.jl:62:+        @testset "Valid Versions" for (pg_version, jl_version) in valid_versions
test/runtests.jl:63:+            @test pg_version == jl_version
test/runtests.jl:64:+        end
@test parse(LibPQ.ConninfoDisplay, "") == LibPQ.Normal
Expand Down Expand Up @@ -82,6 +83,7 @@ end

@testset "Example SELECT" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=false)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)
@test conn isa LibPQ.Connection
@test isopen(conn)
@test status(conn) == LibPQ.libpq_c.CONNECTION_OK
Expand Down Expand Up @@ -190,6 +192,7 @@ end

@testset "Example INSERT and DELETE" begin

Check warning on line 193 in test/runtests.jl

View workflow job for this annotation

GitHub Actions / format 

[JuliaFormatter] reported by reviewdog 🐶


Raw Output:
test/runtests.jl:193:-    @testset "Example INSERT and DELETE" begin
test/runtests.jl:194:-        conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER")
test/runtests.jl:195:-        LibPQ.setnonblocking(conn, nonblock=usenonblocking)
test/runtests.jl:196:-
test/runtests.jl:197:-        result = execute(conn, """
test/runtests.jl:198:-            CREATE TEMPORARY TABLE libpqjl_test (
test/runtests.jl:199:-                no_nulls    varchar(10) PRIMARY KEY,
test/runtests.jl:200:-                yes_nulls   varchar(10)
test/runtests.jl:201:-            );
test/runtests.jl:202:-        """)
test/runtests.jl:203:-        @test status(result) == LibPQ.libpq_c.PGRES_COMMAND_OK
test/runtests.jl:204:-        close(result)
test/runtests.jl:205:-
test/runtests.jl:206:-        # get the data from PostgreSQL and let columntable construct my NamedTuple
test/runtests.jl:207:-        result = execute(conn, """
test/runtests.jl:208:-            SELECT no_nulls, yes_nulls FROM (
test/runtests.jl:209:-                VALUES ('foo', 'bar'), ('baz', NULL)
test/runtests.jl:210:-            ) AS temp (no_nulls, yes_nulls)
test/runtests.jl:211:-            ORDER BY no_nulls DESC;
test/runtests.jl:212:-            """;
test/runtests.jl:213:-            throw_error=true,
test/runtests.jl:214:-        )
test/runtests.jl:215:-        @test status(result) == LibPQ.libpq_c.PGRES_TUPLES_OK
test/runtests.jl:216:-        @test LibPQ.num_rows(result) == 2
test/runtests.jl:217:-        @test LibPQ.num_columns(result) == 2
test/runtests.jl:218:-
test/runtests.jl:219:-        data = columntable(result)
test/runtests.jl:220:-
test/runtests.jl:221:-        @test data[:no_nulls] == ["foo", "baz"]
test/runtests.jl:222:-        @test data[:yes_nulls][1] == "bar"
test/runtests.jl:223:-        @test data[:yes_nulls][2] === missing
test/runtests.jl:224:-
test/runtests.jl:225:-        stmt = LibPQ.load!(
test/runtests.jl:226:-            data,
test/runtests.jl:227:-            conn,
test/runtests.jl:228:-            "INSERT INTO libpqjl_test (no_nulls, yes_nulls) VALUES (\$1, \$2);",
test/runtests.jl:229:-        )
test/runtests.jl:230:-
test/runtests.jl:231:-        @test_throws ArgumentError num_affected_rows(stmt.description)
test/runtests.jl:232:-        @test num_params(stmt) == 2
test/runtests.jl:233:-        @test num_columns(stmt) == 0  # an insert has no results
test/runtests.jl:234:-        @test LibPQ.column_number(stmt, "no_nulls") == 0
test/runtests.jl:235:-        @test LibPQ.column_names(stmt) == []
test/runtests.jl:236:-
test/runtests.jl:237:-        @testset for binary_format in (LibPQ.TEXT, LibPQ.BINARY)
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER")
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

result = execute(conn, """
CREATE TEMPORARY TABLE libpqjl_test (
Expand Down Expand Up @@ -333,6 +336,7 @@ end
@testset "load!" begin

Check warning on line 336 in test/runtests.jl

View workflow job for this annotation

GitHub Actions / format 

[JuliaFormatter] reported by reviewdog 🐶


Raw Output:
test/runtests.jl:336:-    @testset "load!" begin
test/runtests.jl:337:-        @testset "issue #204" begin
test/runtests.jl:338:-            conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER")
test/runtests.jl:339:-            LibPQ.setnonblocking(conn, nonblock=usenonblocking)
test/runtests.jl:146:+            close(result)
test/runtests.jl:147:+            @test !isopen(result)
@testset "issue #204" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER")
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

close(execute(conn, """

Check warning on line 341 in test/runtests.jl

View workflow job for this annotation

GitHub Actions / format 

[JuliaFormatter] reported by reviewdog 🐶


Raw Output:
test/runtests.jl:341:-            close(execute(conn, """
test/runtests.jl:342:-                CREATE TEMPORARY TABLE libpqjl_test (
test/runtests.jl:343:-                    id    serial PRIMARY KEY,
test/runtests.jl:344:-                    data  text[]
test/runtests.jl:345:-                );
test/runtests.jl:346:-            """))
test/runtests.jl:149:+            result = execute(stmt, (1.0, 16); throw_error=false)
test/runtests.jl:150:+            @test result isa LibPQ.Result
test/runtests.jl:151:+            @test status(result) == LibPQ.libpq_c.PGRES_TUPLES_OK
test/runtests.jl:152:+            @test isopen(result)
test/runtests.jl:153:+            @test LibPQ.num_columns(result) == 2
test/runtests.jl:154:+            @test LibPQ.num_rows(result) == 1
test/runtests.jl:155:+            @test LibPQ.column_name(result, 1) == "foo"
test/runtests.jl:156:+            @test LibPQ.column_name(result, 2) == "typname"
CREATE TEMPORARY TABLE libpqjl_test (
Expand All @@ -357,6 +361,7 @@ end
@testset "COPY FROM" begin

Check warning on line 361 in test/runtests.jl

View workflow job for this annotation

GitHub Actions / format 

[JuliaFormatter] reported by reviewdog 🐶


Raw Output:
test/runtests.jl:361:-    @testset "COPY FROM" begin
test/runtests.jl:362:-        @testset "Example COPY FROM" begin
test/runtests.jl:174:+        @testset "Example INSERT and DELETE" begin
@testset "Example COPY FROM" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER")
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

Check warning on line 364 in test/runtests.jl

View workflow job for this annotation

GitHub Actions / format 

[JuliaFormatter] reported by reviewdog 🐶


Raw Output:
test/runtests.jl:364:-            LibPQ.setnonblocking(conn, nonblock=usenonblocking)
test/runtests.jl:365:-
test/runtests.jl:366:-            result = execute(conn, """
test/runtests.jl:367:-                CREATE TEMPORARY TABLE libpqjl_test (
test/runtests.jl:368:-                    no_nulls    varchar(10) PRIMARY KEY,
test/runtests.jl:369:-                    yes_nulls   varchar(10)
test/runtests.jl:370:-                );
test/runtests.jl:371:-            """)
test/runtests.jl:176:+            LibPQ.setnonblocking(conn; nonblock=usenonblocking)
test/runtests.jl:177:+
test/runtests.jl:178:+            result = execute(
test/runtests.jl:179:+                conn,
test/runtests.jl:180:+                """
test/runtests.jl:181:+    CREATE TEMPORARY TABLE libpqjl_test (
test/runtests.jl:182:+        no_nulls    varchar(10) PRIMARY KEY,
test/runtests.jl:183:+        yes_nulls   varchar(10)
test/runtests.jl:184:+    );
test/runtests.jl:185:+""",
test/runtests.jl:186:+            )

result = execute(conn, """
CREATE TEMPORARY TABLE libpqjl_test (
Expand Down Expand Up @@ -401,6 +406,7 @@ end

@testset "Wrong column order" begin

Check warning on line 407 in test/runtests.jl

View workflow job for this annotation

GitHub Actions / format 

[JuliaFormatter] reported by reviewdog 🐶


Raw Output:
test/runtests.jl:407:-        @testset "Wrong column order" begin
test/runtests.jl:408:-            conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER")
test/runtests.jl:409:-            LibPQ.setnonblocking(conn, nonblock=usenonblocking)
test/runtests.jl:410:-
test/runtests.jl:411:-            result = execute(conn, """
test/runtests.jl:412:-                CREATE TEMPORARY TABLE libpqjl_test (
test/runtests.jl:413:-                    pri    bigint PRIMARY KEY,
test/runtests.jl:414:-                    sec    varchar(10)
test/runtests.jl:415:-                );
test/runtests.jl:416:-            """)
test/runtests.jl:417:-            @test status(result) == LibPQ.libpq_c.PGRES_COMMAND_OK
test/runtests.jl:418:-            close(result)
test/runtests.jl:223:+            @testset for binary_format in (LibPQ.TEXT, LibPQ.BINARY)
test/runtests.jl:224:+                result = execute(
test/runtests.jl:225:+                    conn,
test/runtests.jl:226:+                    "SELECT no_nulls, yes_nulls FROM libpqjl_test ORDER BY no_nulls DESC;";
test/runtests.jl:227:+                    throw_error=true,
test/runtests.jl:228:+                    binary_format=binary_format,
test/runtests.jl:229:+                )
test/runtests.jl:230:+                @test status(result) == LibPQ.libpq_c.PGRES_TUPLES_OK
test/runtests.jl:231:+                @test LibPQ.num_rows(result) == 2
test/runtests.jl:232:+                @test LibPQ.num_columns(result) == 2
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER")
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

result = execute(conn, """
CREATE TEMPORARY TABLE libpqjl_test (
Expand Down Expand Up @@ -458,6 +464,7 @@ end
local saved_conn

was_open = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true) do jl_conn
LibPQ.setnonblocking(jl_conn, nonblock=usenonblocking)
saved_conn = jl_conn
return isopen(jl_conn)
end
Expand All @@ -466,6 +473,7 @@ end
@test !isopen(saved_conn)

@test_throws LibPQ.Errors.PQConnectionError LibPQ.Connection("dbname=123fake user=$DATABASE_USER"; throw_error=true) do jl_conn
LibPQ.setnonblocking(conn, nonblock=usenonblocking)
saved_conn = jl_conn
@test false
end
Expand All @@ -475,13 +483,15 @@ end

@testset "Version Numbers" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

# update this test before PostgreSQL 20.0 ;)
@test LibPQ.pqv"7" <= LibPQ.server_version(conn) <= LibPQ.pqv"20"
end

@testset "Encoding" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

@test LibPQ.encoding(conn) == "UTF8"

Expand Down Expand Up @@ -513,6 +523,7 @@ end
throw_error=true,
type_map=Dict(:interval => String),
)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

conn_info = LibPQ.conninfo(conn)
options = first(filter(conn_info) do conn_opt
Expand Down Expand Up @@ -632,6 +643,8 @@ end
@testset "Finalizer" begin
closed_flags = map(1:50) do _
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER")
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

closed = conn.closed
finalize(conn)
return closed
Expand All @@ -646,6 +659,8 @@ end

closed_flags = map(1:50) do _
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER")
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

push!(results, execute(conn, "SELECT 1;"))
return conn.closed
end
Expand All @@ -661,6 +676,8 @@ end
# with AsyncResults, which hold a reference to Connection
closed_flags = asyncmap(1:50) do _
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER")
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

wait(async_execute(conn, "SELECT pg_sleep(1);"))
return conn.closed
end
Expand Down Expand Up @@ -707,6 +724,8 @@ end

@testset "throw_error=false" begin
conn = LibPQ.Connection("dbname=123fake user=$DATABASE_USER"; throw_error=false)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

@test conn isa LibPQ.Connection
@test status(conn) == LibPQ.libpq_c.CONNECTION_BAD
@test isopen(conn)
Expand All @@ -725,6 +744,8 @@ end
@test_throws LibPQ.Errors.PQConnectionError LibPQ.Connection("dbname=123fake user=$DATABASE_USER"; throw_error=true)

conn = LibPQ.Connection("dbname=123fake user=$DATABASE_USER"; throw_error=false)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

@test conn isa LibPQ.Connection
@test status(conn) == LibPQ.libpq_c.CONNECTION_BAD
@test isopen(conn)
Expand All @@ -740,6 +761,7 @@ end
@testset "Results" begin
@testset "Nulls" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

result = execute(conn, "SELECT NULL"; throw_error=true)
@test status(result) == LibPQ.libpq_c.PGRES_TUPLES_OK
Expand Down Expand Up @@ -824,6 +846,7 @@ end

@testset "Not Nulls" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

result = execute(conn, "SELECT NULL"; not_null=[false], throw_error=true)
@test status(result) == LibPQ.libpq_c.PGRES_TUPLES_OK
Expand Down Expand Up @@ -949,6 +972,7 @@ end

@testset "Tables.jl" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

result = execute(conn, """
SELECT no_nulls, yes_nulls FROM (
Expand Down Expand Up @@ -991,6 +1015,7 @@ end

@testset "Duplicate names" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

result = execute(conn, "SELECT 1 AS col, 2 AS col;", not_null=true, throw_error=true)
columns = Tables.columns(result)
Expand All @@ -1007,6 +1032,7 @@ end

@testset "Uppercase Columns" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

result = execute(conn, "SELECT 1 AS \"Column\";")
@test num_columns(result) == 1
Expand All @@ -1025,6 +1051,7 @@ end

@testset "PQResultError" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

try
execute(conn, "SELECT log(-1);")
Expand Down Expand Up @@ -1072,6 +1099,7 @@ end
@testset "Type Conversions" begin
@testset "Deprecations" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

result = execute(conn, "SELECT 'infinity'::timestamp;")

Expand All @@ -1089,6 +1117,7 @@ end

@testset "Automatic" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

result = execute(conn, """
SELECT oid, typname, typlen, typbyval, typcategory
Expand Down Expand Up @@ -1120,6 +1149,7 @@ end

@testset "Overrides" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

result = execute(conn, "SELECT 4::bigint;")
@test first(first(result)) === Int64(4)
Expand Down Expand Up @@ -1169,6 +1199,7 @@ end
@testset for binary_format in (LibPQ.TEXT, LibPQ.BINARY)
@testset "Default Types" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

test_data = [
("3", Cint(3)),
Expand Down Expand Up @@ -1335,6 +1366,7 @@ end

@testset "Specified Types" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

test_data = [
("3", UInt, UInt(3)),
Expand Down Expand Up @@ -1428,6 +1460,7 @@ end

@testset "Parameters" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

@testset "Arrays" begin
tests = (
Expand Down Expand Up @@ -1542,6 +1575,7 @@ end

@testset "SQLString" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER")
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

execute(conn, sql```
CREATE TEMPORARY TABLE libpq_test_users (
Expand Down Expand Up @@ -1577,6 +1611,7 @@ end
@testset "Query Errors" begin
@testset "Syntax Errors" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

result = execute(conn, "SELORCT NUUL;"; throw_error=false)
@test status(result) == LibPQ.libpq_c.PGRES_FATAL_ERROR
Expand All @@ -1595,6 +1630,7 @@ end

@testset "Wrong No. Parameters" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

result = execute(conn, "SELORCT \$1;", String[]; throw_error=false)
@test status(result) == LibPQ.libpq_c.PGRES_FATAL_ERROR
Expand All @@ -1619,6 +1655,7 @@ end

@testset "Interface Errors" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

result = execute(
conn,
Expand Down Expand Up @@ -1652,6 +1689,7 @@ end

# Establish connection and construct temporary table.
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER")
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

# Get the column.
result = execute(
Expand All @@ -1678,6 +1716,7 @@ end
@testset "Statements" begin
@testset "No Params, Output" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

stmt = prepare(conn, "SELECT oid, typname FROM pg_type")

Expand All @@ -1699,6 +1738,7 @@ end

@testset "Params, Output" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

stmt = prepare(conn, "SELECT oid, typname FROM pg_type WHERE oid = \$1")

Expand All @@ -1723,11 +1763,13 @@ end
end
end

@testset "AsyncResults" begin
@testset "AsyncResults (usenonblocking connection=$usenonblocking)" for usenonblocking in [true, false]
@info "usenonblocking" usenonblocking
trywait(ar::LibPQ.AsyncResult) = (try wait(ar) catch end; nothing)

@testset "Basic" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

ar = async_execute(conn, "SELECT pg_sleep(2);"; throw_error=false)
yield()
Expand All @@ -1750,6 +1792,7 @@ end

@testset "Parameters" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

ar = async_execute(
conn,
Expand Down Expand Up @@ -1782,6 +1825,7 @@ end
# Ensures queries wait for previous query completion before starting
@testset "Wait in line to complete" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

first_ar = async_execute(conn, "SELECT pg_sleep(4);")
yield()
Expand Down Expand Up @@ -1811,6 +1855,7 @@ end

@testset "Cancel" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

# final query needs to be one that actually does something
# on Windows, first query also needs to do something
Expand Down Expand Up @@ -1843,6 +1888,7 @@ end

@testset "Canceled by closing connection" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

# final query needs to be one that actually does something
# on Windows, first query also needs to do something
Expand Down Expand Up @@ -1875,6 +1921,7 @@ end

@testset "FDWatcher: bad file descriptor (EBADF)" begin
conn = LibPQ.Connection("dbname=postgres user=$DATABASE_USER"; throw_error=true)
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

ar = async_execute(conn, "SELECT pg_sleep(3); SELECT * FROM pg_type;")
yield()
Expand All @@ -1898,6 +1945,7 @@ end
@testset "DBInterface integration" begin
conn = DBInterface.connect(LibPQ.Connection, "dbname=postgres user=$DATABASE_USER")
@test conn isa LibPQ.Connection
LibPQ.setnonblocking(conn, nonblock=usenonblocking)

result = DBInterface.execute(
conn,
Expand Down

0 comments on commit 6c7f795

Please sign in to comment.