Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding IndHyperslab, fixing IndHalfspace and Linear #62

Merged
merged 2 commits into from
Nov 17, 2018
Merged

Conversation

lostella
Copy link
Member

This:

  • adds IndHyperslab, partially addressing Missing functions and calculus rules #58 (very partially)
  • fixes IndHalfspace in that the improper case is detected, and AbstractArrays are allowed instead of just AbstractVectors
  • fixes Linear in that only real coefficients are allowed
  • makes parametric types a bit cleaner in all of the above

@codecov
Copy link

codecov bot commented Nov 11, 2018

Codecov Report

Merging #62 into master will decrease coverage by 36.26%.
The diff coverage is 85%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #62       +/-   ##
===========================================
- Coverage   96.79%   60.53%   -36.27%     
===========================================
  Files          68       70        +2     
  Lines        1248     2037      +789     
===========================================
+ Hits         1208     1233       +25     
- Misses         40      804      +764
Impacted Files Coverage Δ
src/ProximalOperators.jl 48% <ø> (-52%) ⬇️
src/functions/linear.jl 73.33% <ø> (-26.67%) ⬇️
src/functions/indHyperslab.jl 84% <84%> (ø)
src/functions/indHalfspace.jl 62.5% <86.66%> (-4.17%) ⬇️
src/functions/indFree.jl 27.77% <0%> (-72.23%) ⬇️
src/utilities/linops.jl 40% <0%> (-60%) ⬇️
src/calculus/tilt.jl 42.1% <0%> (-57.9%) ⬇️
src/calculus/translate.jl 44% <0%> (-56%) ⬇️
src/calculus/postcompose.jl 46.42% <0%> (-53.58%) ⬇️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6451b4...233bb57. Read the comment docs.

@lostella
Copy link
Member Author

Coverage drop due to JuliaCI/Coverage.jl#187

improved IndHalfspace

added IndHyperslab

improved and simplified IndHalfspace and IndHyperslab

added IndHyperslab to docs

getting tolerances right
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant