Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TotalVariation.jl to run, defining benchmark/Project.toml. #39

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Update TotalVariation.jl to run, defining benchmark/Project.toml. #39

wants to merge 1 commit into from

Conversation

daniel-vainsencher
Copy link
Contributor

Might become a PR to bring more benchmarks to running state, feedback welcome.

@daniel-vainsencher daniel-vainsencher mentioned this pull request Jun 21, 2022
Open
lostella
lostella approved these changes Jun 25, 2022
View reviewed changes
Copy link
Member

@lostella lostella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! What Julia version did you run this on?

The package and tests needs quite an update I believe, especially for it to work with the latest ProximalAlgorithms

@daniel-vainsencher
Copy link
Contributor Author

Ran it 1.7.2, with Manifest.toml saying:

...
1054:[[deps.ProximalAlgorithms]]
1055:deps = ["LinearAlgebra", "Printf", "ProximalOperators"]
1056-git-tree-sha1 = "55476be8224b3db55f0bf862f2f84ac8597aaae5"
1057-uuid = "140ffc9f-1907-541a-a177-7475e0a401e9"
1058-version = "0.4.1"
1059-
1060:[[deps.ProximalOperators]]
1061-deps = ["IterativeSolvers", "LinearAlgebra", "OSQP", "SparseArrays", "SuiteSparse", "TSVD"]
1062-git-tree-sha1 = "d32ba50ff3e3192a3d4b9510618b9670d6925009"
1063-uuid = "a725b495-10eb-56fe-b38b-717eba820537"
1064-version = "0.14.2"
...
1247-[[deps.StructuredOptimization]]
1248:deps = ["AbstractOperators", "DSP", "FFTW", "LinearAlgebra", "ProximalAlgorithms", "ProximalOperators", "RecursiveArrayTools"]
1249-git-tree-sha1 = "35bc5ae5ba1177ee119fabf40980d799c06b4ed2"
1250-uuid = "46cd3e9d-64ff-517d-a929-236bc1a1fc9d"
1251-version = "0.3.0"
...

So coming up to latest versions of everything is indeed additional work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lostella lostella lostella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-vainsencher @lostella