Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Remove longer idle timeout #608

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IanButterworth
Copy link
Collaborator

@IanButterworth IanButterworth commented Jan 14, 2022

Further to #607 I think it's reasonable to reduce this timeout because it will still be hit now if a Gtk window is open but idle.

If the reason for the blocking is determined and fixed (given it was reported to not happen on earlier julia versions), the 5s number could be reinstated. I assume the timeout was just made to be 5s when it used to not block..

With a Gtk window open and idle:

Master (v1.1.11)

julia> multifoo() = @time Threads.@threads for _ in 1:Threads.nthreads()
           sleep(0.1)
       end
multifoo (generic function with 1 method)

julia> for _ in 1:10
       multifoo()
       end
  0.109436 seconds (15.29 k allocations: 833.890 KiB, 7.25% compilation time)
  5.106435 seconds (162 allocations: 9.922 KiB)
  5.107450 seconds (166 allocations: 10.531 KiB)
  5.106775 seconds (163 allocations: 9.938 KiB)
  0.101773 seconds (164 allocations: 9.953 KiB)
  5.106659 seconds (164 allocations: 10.500 KiB)
  5.105468 seconds (165 allocations: 9.969 KiB)
  0.101641 seconds (162 allocations: 9.922 KiB)
  5.106656 seconds (163 allocations: 10.484 KiB)
  0.101961 seconds (163 allocations: 9.938 KiB)

This PR

julia> for _ in 1:10
       multifoo()
       end
  0.122006 seconds (15.30 k allocations: 834.062 KiB, 8.47% compilation time)
  0.102200 seconds (174 allocations: 10.109 KiB)
  0.112659 seconds (175 allocations: 10.672 KiB)
  0.101423 seconds (170 allocations: 10.047 KiB)
  0.101416 seconds (170 allocations: 10.047 KiB)
  0.101732 seconds (171 allocations: 10.609 KiB)
  0.101754 seconds (171 allocations: 10.062 KiB)
  0.101853 seconds (171 allocations: 10.062 KiB)
  0.101157 seconds (171 allocations: 10.609 KiB)
  0.101811 seconds (170 allocations: 10.047 KiB)

Neither case registers any noticeable activity on my cpu monitor

@IanButterworth IanButterworth changed the title Reduce idle timeout from 5s to 0.1s Remove longer idle timeout Jan 14, 2022
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #608 (caab4a3) into master (cea01eb) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
- Coverage   57.58%   57.55%   -0.04%     
==========================================
  Files          32       32              
  Lines        2695     2695              
==========================================
- Hits         1552     1551       -1     
- Misses       1143     1144       +1     
Impacted Files Coverage Δ
src/GLib/signals.jl 77.95% <0.00%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cea01eb...caab4a3. Read the comment docs.

@tknopp
Copy link
Collaborator

tknopp commented Jan 14, 2022

I think there was some reason for this, which applied to windows. Can you test it on Windows?

@IanButterworth
Copy link
Collaborator Author

IanButterworth commented Jan 14, 2022

Ah, ok. I don't have access to windows I'm afraid. If I do I'll try it out. This is far less urgent than the other one IMO.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants