Print information about static nature of graph in display #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `show` function is only overloaded for inline printing, but when displaying the graph, the information about its static nature is missing, potentially confusing users:
```
julia> g
{58089, 120148} directed simple Int32 graph
julia> (g, nothing)
({58089, 120148} directed simple static {Int32, Int32} graph, nothing)
```
This PR fixes that.
|
I wonder if the 2 arg show method should perhaps be removed? |
|
I'm never quite sure about this. Wouldn't it then print the "ugly" style when inline? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
showfunction is only overloaded for inline printing, but when displaying the graph, the information about its static nature is missing, potentially confusing users:This PR fixes that.