Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarifies stream seeking for querying and detection functions #177

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ssfrr
Copy link
Contributor

@ssfrr ssfrr commented Mar 20, 2018

The query infrastructure was already handling seeking around the stream
before and after calling the detect functions, so they shouldn't have to
worry about it. This also sets the example in the README to skip the magic
bytes in load(::Stream) instead of load(::File).

fixes #163

@ssfrr ssfrr force-pushed the detect-positioning branch from c451aa1 to 11a8921 Compare March 5, 2019 02:32
@timholy
Copy link
Member

timholy commented Mar 3, 2021

Ugh, I just noticed this. If you want something like this it will likely be easier to start from scratch. I am not 100% certain we've been as careful as we should be about the stream position upon exit, or even what the right default really is. Maybe the detector should leave the position as-is after successful detection?

Happy to help you get this over the finish line if you're still interested.

@ViralBShah ViralBShah marked this pull request as draft November 7, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should load(::Stream, ...) methods skip magic bytes?
2 participants