Skip to content

Commit

Permalink
Merge pull request #591 from JuliaIO/dev
Browse files Browse the repository at this point in the history 
Draft: v0.4.54
  • Loading branch information
@JonasIsensee
JonasIsensee authored Sep 8, 2024
2 parents b9fdf3e + a750162 commit cd2b137
Show file tree
Hide file tree
Showing 15 changed files with 266 additions and 346 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/Downgrade.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
paths-ignore:
- 'docs/**'
push:
branches: [main, master, dev]
branches: [main, master]
paths-ignore:
- 'docs/**'
concurrency:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
pull_request:
branches: [main, master, dev]
push:
branches: [main, master, dev]
branches: [main, master]
tags: '*'
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/stale_preview_removal.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Doc Preview Cleanup

on:
schedule:
- cron: "0 0 * * *"
- cron: "0 0 1 * *"

jobs:
doc-preview-cleanup:
Expand All @@ -17,8 +17,8 @@ jobs:
shell: julia {0}
run: |
using Pkg
pkg"activate --temp"
pkg"add HTTP JSON3"
Pkg.activate(; temp=true)
Pkg.add(["HTTP", "JSON3"])
using HTTP
using JSON3
Expand All @@ -43,8 +43,7 @@ jobs:
end
return prs
end
prs = all_prs()
open_within_threshold = map(x -> x.number, filter(prs) do pr
open_within_threshold = map(x -> x.number, filter(all_prs()) do pr
time = DateTime(pr.updated_at[1:19], ISODateTimeFormat)
return pr.state == "open" && Dates.days(now() - time) <= retention_days
end)
Expand All @@ -54,7 +53,7 @@ jobs:
if isempty(stale_previews)
@info "No stale previews"
exit(1)
exit(0)
end
for pr in stale_previews
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 0.5.0
- Improved encoding of committed datatypes.
This fixes longstanding issues but new files will not be loaded correctly with JLD2 versions prior to `v0.5.0`.
Existing files remain readable.
- JLD2 now warns when storing structures containing `<: Function` objects.

## 0.4.53
- Experimental: Slicing and inplace updating of array datasets
- updated CI workflows
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "JLD2"
uuid = "033835bb-8acc-5ee8-8aae-3f567f8a3819"
version = "0.4.53"
version = "0.5.0"

[deps]
FileIO = "5789e2e9-d7fb-5bc7-8068-2c6fae9b9549"
Expand Down
6 changes: 3 additions & 3 deletions src/committed_datatype_introspection.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ function stringify_committed_datatype(f, cdt; showfields=false)
return julia_type_str, written_type_str, String[]
end

field_datatypes = read_field_datatypes(f, attrs)
field_datatypes = read_field_datatypes(f, dt, attrs)
field_strs = String[]
do_report = false
for i = 1:length(dt.names)
if !isempty(field_datatypes) && (ref = field_datatypes[i]) != NULL_REFERENCE
for (i, key) in enumerate(keys(field_datatypes))
if (ref = field_datatypes[string(key)]) != NULL_REFERENCE
fieldtype = stringify_committed_datatype(f, f.datatype_locations[ref])[1]
do_report = true
else
Expand Down
Loading

2 comments on commit cd2b137

@JonasIsensee
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/114759

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.5.0 -m "<description of version>" cd2b1378b4f8831684287fd70a1377a87c5e3b08
git push origin v0.5.0

Please sign in to comment.