-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backports-release-1.11] fix pkgdir during inits on 1.11 #56546
base: backports-release-1.11
Are you sure you want to change the base?
[backports-release-1.11] fix pkgdir during inits on 1.11 #56546
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you cannot move this here because we rely on the require lock remaining held during this function for safety
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see, this is actually moving it later? I guess that seems okay
Can someone explain why you want to call this in init? |
I don't have a defense. If you want to look into the issue in the ecosystem JuliaIO/JLD2.jl#610 But I don't think we should be fixing this by changing user code. It works on 1.10 and master |
@vtjnash this appears to now avoid a deadlock that tests expected
I think that's a good thing? |
That means you've introduced a new data race. Although I don't see precisely why, I think it is because of the expected failures without the fixes for it from #56329 |
I can't figure out why either.
I don't follow this, sorry. |
The test ensures that the fixes in #56329 are present |
So we mark the test as broken on 1.11 ? |
@vtjnash I've done that, but this does need approval. |
Proposed fix for #56077 on 1.11