[Auditor] Don't try to dlopen libraries for incompatible ISAs #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
force-pushed
the
mg/march-comparison-strategy
branch
2 times, most recently
from
a420053
to
664dcd7
Compare
|
So, I verified that this fixes the attempt to dlopen the library for an incompatible ISA, but for some reasons I still don't grasp audit fails anyway to locate the products 😕 I'll need to do more debugging. |
giordano
force-pushed
the
mg/march-comparison-strategy
branch
from
664dcd7
to
30d6ac9
Compare
|
It turns out we try to dlopen libraries twice.... 🤦 We need to repeat the same exact thing in https://github.com/JuliaPackaging/BinaryBuilderBase.jl/blob/55c795dbca6c74b076636bdcfdccbfeb34063eb7/src/Products.jl#L225: JuliaPackaging/BinaryBuilderBase.jl#233 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1193.