Remove separate source_urls wizard field #1293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goes with JuliaPackaging/BinaryBuilderBase.jl#322. Part of the problem with the current setup is that the WizardState doesn't actually round trip properly, because the cache for archive downloads gets deleted. It could be reconstituted from source_urls of course, but it would be cleaner to just do that on-demand with the SetupSource (though this commit doesn't do that yet).
Keno
force-pushed
the
kf/wizardsourceurls
branch
from
4bb7f6d
to
a0032c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes with JuliaPackaging/BinaryBuilderBase.jl#322. Part of the problem with the current setup is that the WizardState doesn't actually round trip properly, because the cache for archive downloads gets deleted. It could be reconstituted from source_urls of course, but it would be cleaner to just do that on-demand with the SetupSource (though this commit doesn't do that yet).