[Rootfs] Restore the old version of patchelf #7733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amontoison would you be able to publish this as you did before? I won't be able to do it myself this week. |
giordano
reviewed
Nov 29, 2023
| @@ -117,7 +117,7 @@ sources = [ | |||
| "c68e441d2b93074b01ea193cb17e944ed751750f"), # v2.54 | |||
| # As is patchelf | |||
| GitSource("https://github.com/NixOS/patchelf.git", | |||
| "99c24238981b7b1084313aca8f5c493bb46f302c"), # v0.18.0 | |||
| "bf3f37ec29edcdb3e2a163edaf84aeece39f8c9d"), # v0.14.3 | |||
There was a problem hiding this comment.
It'd be good to leave a comment to explain we don't want to upgrade patchelf unless there's a compelling and proved reason to do it because of previous problems we experienced, with references to the error message and a link to discussion.
Yes, I can do that Mosè. I will just be unable to merge the PR in BinaryBuilderBase.jl because I don't have the rights for this repository. |
grasph
pushed a commit
to Moelf/Yggdrasil
that referenced
this pull request
Jul 1, 2024
* [Rootfs] Restore the old version of patchelf * Add a comment to explain why we don't want to upgrade patchelf
|
For future record, the issue mentioned at #7728 (comment) is NixOS/patchelf#492 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7728 (comment)
Companion PR in BBB: JuliaPackaging/BinaryBuilderBase.jl#354