Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute description enhancement - proof of demo #4604

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ininterrompue
Copy link

@Ininterrompue Ininterrompue commented Dec 15, 2022

Enhances descriptions for the following histogram-related attributes as a proof of demonstration:

  • bins
  • show_empty_bins
  • weights

Two issues:

  1. The links are definitely not ideal - help wanted to make this clean. Goal: series attributes should link to relevant series types docstrings on the API page.
  2. There's a bunch of newlines \n (and also present in the current descriptions) - help wanted to hide these

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 90.77% // Head: 90.80% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (2dd080d) compared to base (a21d2ad).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4604      +/-   ##
==========================================
+ Coverage   90.77%   90.80%   +0.03%     
==========================================
  Files          41       41              
  Lines        8771     8781      +10     
==========================================
+ Hits         7962     7974      +12     
+ Misses        809      807       -2     
Impacted Files Coverage Δ
src/args.jl 84.98% <0.00%> (-0.30%) ⬇️
src/axes.jl 89.87% <0.00%> (-0.09%) ⬇️
src/backends/pgfplotsx.jl 88.88% <0.00%> (-0.03%) ⬇️
src/shorthands.jl 96.15% <0.00%> (ø)
RecipesPipeline/src/RecipesPipeline.jl 100.00% <0.00%> (ø)
src/backends/gr.jl 91.66% <0.00%> (+<0.01%) ⬆️
src/components.jl 90.62% <0.00%> (+0.02%) ⬆️
src/utils.jl 92.65% <0.00%> (+0.15%) ⬆️
src/backends/gaston.jl 95.77% <0.00%> (+0.24%) ⬆️
src/backends.jl 82.58% <0.00%> (+0.26%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -2,6 +2,9 @@ const AStr = AbstractString
const ColorType = Union{Symbol,Colorant,PlotUtils.ColorSchemes.ColorScheme,Integer}
const TicksType = Union{AVec{Real},Tuple{AVec{Real},AVec{AStr}},Symbol}

link_histogram = "[`histogram`](https://docs.juliaplots.org/stable/api/#Plots.histogram-Tuple)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good idea, although this is not really aimed toward being maintainable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an option would be to insert some sort of tag like e.g. [:histogram:] and then replace that with the link when building the ducumentation.

Ideally that would then end up in the docstring as well, but I don't see a way to make that happen

@t-bltg
Copy link
Member

t-bltg commented Feb 9, 2023

I don't want to block any good effort towards having cleaner and enhanced docs.

So @Ininterrompue tell us when you want this merged (and when you think it is ready).

@BeastyBlacksmith, does this looks good to you ?

@t-bltg t-bltg added documentation - API enhancement improving existing functionality labels Feb 9, 2023
@BeastyBlacksmith
Copy link
Member

In its current state it doesn't produce usable docs. Though its heading in a good direction.

@BeastyBlacksmith BeastyBlacksmith marked this pull request as draft February 9, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation - API enhancement improving existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants