Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Transition to package extensions #231

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kiranshila
Copy link

@kiranshila kiranshila commented May 18, 2024

Since Julia 1.9, the recommended way to have optional dependencies and additional code that adds support for those optional dependencies is Package Extensions. This is a WIP PR to reorganize ADNLPModels to support them.

There are several benefits. First, the ability to precompile the extensions decreases the TTFx of code using the extensions, which is always good. Second, we can specify compat of the extensions' dependencies. This is really useful as AD backends like Enzyme are a little unstable and benefit from explicit, tagged versions.

Current Blockers

  • The Symbolics extension introduces new symbols, something that is generally unsupported by extensions. There is a workaround on the dev docs here, but I can't seem to make it work in tests
  • This transition bumps the julia compat up to 1.9, away from the LTS release of 1.6. Is this acceptable? There are workarounds to keep the compat while using package extensions but I thought I'd try to just get extensions working first.

Additional Edits

I took the liberty of also removing the test Project.toml as current best practice is to define all the dependencies (including test deps) in the top level toml file and use extras and targets.

Copy link
Contributor

Package name latest stable
CaNNOLeS.jl
DCISolver.jl
DerivativeFreeSolvers.jl
JSOSolvers.jl
NLPModelsIpopt.jl
OptimizationProblems.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl

@kiranshila
Copy link
Author

Actually, I think this is way harder than I expected because of all the new data types. It seems like this might need some serious restructuring to fit into the package extension style.

@tmigot
Copy link
Member

tmigot commented May 20, 2024

Hi @kiranshila ! Thanks for working on this. Droping Julia version before 1.9 is a big decision though that I would prefer to delay for the moment if that's ok for you?

I took the liberty of also removing the test Project.toml as current best practice is to define all the dependencies (including test deps) in the top level toml file and use extras and targets.

Do you have any link related to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants