Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 💡 Change optional args of select_optimizers to kwargs #160

Merged
merged 1 commit into from
Jun 1, 2024
Merged

refactor: 💡 Change optional args of select_optimizers to kwargs #160

merged 1 commit into from
Jun 1, 2024

Conversation

abelsiqueira
Copy link
Member

BREAKING CHANGE: 🧨 The API of select_optimizers changed to not have positional optional
arguments. The problem is mandatory and the other arguments are
keywords.

✅ Closes: #159

@abelsiqueira
refactor: 💡 Change optional args of select_optimizers to kwargs
5f06455 
BREAKING CHANGE: 🧨 The API of select_optimizers changed to not have positional optional
arguments. The problem is mandatory and the other arguments are
keywords.

✅ Closes: #159
@github-actions GitHub Actions
Copy link
Contributor

Benchmark result

Judge result

Benchmark Report for /home/runner/work/JSOSuite.jl/JSOSuite.jl

Job Properties

  • Time of benchmarks:
    • Target: 31 May 2024 - 10:30
    • Baseline: 31 May 2024 - 10:31
  • Package commits:
    • Target: 395d44
    • Baseline: 83a13f
  • Julia commits:
    • Target: 0b4590
    • Baseline: 0b4590
  • Julia command flags:
    • Target: None
    • Baseline: None
  • Environment variables:
    • Target: None
    • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["solvers"]

Julia versioninfo

Target

Julia Version 1.10.3
Commit 0b4590a5507 (2024-04-30 10:59 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.4 LTS
  uname: Linux 6.5.0-1021-azure #22~22.04.1-Ubuntu SMP Tue Apr 30 16:08:18 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  2445 MHz       1682 s          0 s        140 s       2674 s          0 s
       #2  3179 MHz       1763 s          0 s        119 s       2605 s          0 s
       #3  3304 MHz       1626 s          0 s        136 s       2726 s          0 s
       #4  3243 MHz       1843 s          0 s        145 s       2507 s          0 s
  Memory: 15.606502532958984 GB (13971.69921875 MB free)
  Uptime: 452.63 sec
  Load Avg:  1.73  1.74  0.85
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline

Julia Version 1.10.3
Commit 0b4590a5507 (2024-04-30 10:59 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.4 LTS
  uname: Linux 6.5.0-1021-azure #22~22.04.1-Ubuntu SMP Tue Apr 30 16:08:18 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  3243 MHz       1815 s          0 s        146 s       3032 s          0 s
       #2  2445 MHz       1840 s          0 s        127 s       3018 s          0 s
       #3  2679 MHz       1788 s          0 s        142 s       3047 s          0 s
       #4  2775 MHz       1974 s          0 s        155 s       2864 s          0 s
  Memory: 15.606502532958984 GB (13877.3671875 MB free)
  Uptime: 502.52 sec
  Load Avg:  1.36  1.64  0.87
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Target result

Benchmark Report for /home/runner/work/JSOSuite.jl/JSOSuite.jl

Job Properties

  • Time of benchmark: 31 May 2024 - 10:30
  • Package commit: 395d44
  • Julia commit: 0b4590
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["solvers", "LBFGS"] 36.679 μs (5%) 17.65 KiB (1%) 422
["solvers", "Percival"] 63.478 μs (5%) 28.12 KiB (1%) 385
["solvers", "R2"] 211.415 μs (5%) 90.98 KiB (1%) 5489
["solvers", "TRON"] 60.624 μs (5%) 58.62 KiB (1%) 571
["solvers", "TRUNK"] 33.734 μs (5%) 27.95 KiB (1%) 277

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["solvers"]

Julia versioninfo

Julia Version 1.10.3
Commit 0b4590a5507 (2024-04-30 10:59 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.4 LTS
  uname: Linux 6.5.0-1021-azure #22~22.04.1-Ubuntu SMP Tue Apr 30 16:08:18 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  2445 MHz       1682 s          0 s        140 s       2674 s          0 s
       #2  3179 MHz       1763 s          0 s        119 s       2605 s          0 s
       #3  3304 MHz       1626 s          0 s        136 s       2726 s          0 s
       #4  3243 MHz       1843 s          0 s        145 s       2507 s          0 s
  Memory: 15.606502532958984 GB (13971.69921875 MB free)
  Uptime: 452.63 sec
  Load Avg:  1.73  1.74  0.85
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline result

Benchmark Report for /home/runner/work/JSOSuite.jl/JSOSuite.jl

Job Properties

  • Time of benchmark: 31 May 2024 - 10:31
  • Package commit: 83a13f
  • Julia commit: 0b4590
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["solvers", "LBFGS"] 37.510 μs (5%) 17.65 KiB (1%) 422
["solvers", "Percival"] 63.669 μs (5%) 28.12 KiB (1%) 385
["solvers", "R2"] 207.246 μs (5%) 90.98 KiB (1%) 5489
["solvers", "TRON"] 59.371 μs (5%) 58.62 KiB (1%) 571
["solvers", "TRUNK"] 33.583 μs (5%) 27.95 KiB (1%) 277

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["solvers"]

Julia versioninfo

Julia Version 1.10.3
Commit 0b4590a5507 (2024-04-30 10:59 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.4 LTS
  uname: Linux 6.5.0-1021-azure #22~22.04.1-Ubuntu SMP Tue Apr 30 16:08:18 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  3243 MHz       1815 s          0 s        146 s       3032 s          0 s
       #2  2445 MHz       1840 s          0 s        127 s       3018 s          0 s
       #3  2679 MHz       1788 s          0 s        142 s       3047 s          0 s
       #4  2775 MHz       1974 s          0 s        155 s       2864 s          0 s
  Memory: 15.606502532958984 GB (13877.3671875 MB free)
  Uptime: 502.52 sec
  Load Avg:  1.36  1.64  0.87
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() lbt
Sys.CPU_THREADS 4

lscpu output:

Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Address sizes:                      48 bits physical, 48 bits virtual
Byte Order:                         Little Endian
CPU(s):                             4
On-line CPU(s) list:                0-3
Vendor ID:                          AuthenticAMD
Model name:                         AMD EPYC 7763 64-Core Processor
CPU family:                         25
Model:                              1
Thread(s) per core:                 2
Core(s) per socket:                 2
Socket(s):                          1
Stepping:                           1
BogoMIPS:                           4890.86
Flags:                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid aperfmperf pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext invpcid_single vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves clzero xsaveerptr rdpru arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload umip vaes vpclmulqdq rdpid fsrm
Virtualization:                     AMD-V
Hypervisor vendor:                  Microsoft
Virtualization type:                full
L1d cache:                          64 KiB (2 instances)
L1i cache:                          64 KiB (2 instances)
L2 cache:                           1 MiB (2 instances)
L3 cache:                           32 MiB (1 instance)
NUMA node(s):                       1
NUMA node0 CPU(s):                  0-3
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit:        Not affected
Vulnerability L1tf:                 Not affected
Vulnerability Mds:                  Not affected
Vulnerability Meltdown:             Not affected
Vulnerability Mmio stale data:      Not affected
Vulnerability Retbleed:             Not affected
Vulnerability Spec rstack overflow: Vulnerable: Safe RET, no microcode
Vulnerability Spec store bypass:    Vulnerable
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; Retpolines; STIBP disabled; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Not affected
Cpu Property Value
Brand AMD EPYC 7763 64-Core Processor
Vendor :AMD
Architecture :Unknown
Model Family: 0xaf, Model: 0x01, Stepping: 0x01, Type: 0x00
Cores 16 physical cores, 16 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 512, 32768) kbytes
64 byte cache line size
Address Size 48 bits virtual, 48 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC runs at constant rate (invariant from clock frequency)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@abelsiqueira abelsiqueira requested a review from tmigot May 31, 2024 12:16
tmigot
tmigot approved these changes Jun 1, 2024
View reviewed changes
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @abelsiqueira!

@tmigot tmigot added the breaking Change that requires a new breaking release label Jun 1, 2024
@tmigot tmigot merged commit b185280 into main Jun 1, 2024
15 checks passed
@tmigot tmigot deleted the 159-refactor branch June 1, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmigot tmigot tmigot approved these changes

Assignees
No one assigned
Labels
breaking Change that requires a new breaking release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor select_optimizers to have only the problem as positional
2 participants
@abelsiqueira @tmigot