Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requiredFeatureCount struct assignment #22

Merged
merged 1 commit into from
May 3, 2024

Conversation

JeffreyPalmer
Copy link
Contributor

I noticed that there was a warning in the repl logs when running the triangle example about setting a non-existent struct field. I fixed it by replacing the assignment to requiredFeaturesCount with requiredFeatureCount, as is in the WebGPU header.

Thanks for your work on this!

@arhik
Copy link
Member

arhik commented May 3, 2024

@JeffreyPalmer check fails are not related to your PR.

Note for later reference:
Checks are done against master (dev) branch as per CI.yml. But currently Core is lagging behind and is using WGPUNative v0.1.4. Fix is to somehow make CI to use compatible WGPUNative version. It will also be good move for future checks.

@arhik arhik merged commit 0eadcbc into JuliaWGPU:main May 3, 2024
0 of 3 checks passed
arhik referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants