Skip to content

Commit

Permalink
Rename from connection_timeout -> connect_timeout (#1131)
Browse files Browse the repository at this point in the history
I think this may be a typo; I'm a little surprised there's not a warning or something that you're using a useless keyword argument.
  • Loading branch information
staticfloat authored Nov 28, 2023
1 parent b4d3e38 commit f9389ae
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/client.jl
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ end
# Put it back in 10 seconds
Timer(t->HTTP.Connections.releaseconnection(dummy_conn, false), 10; interval=0)
# If we count the time it takes to acquire the connection from the pool, we'll get a timeout error.
HTTP.get("https://$httpbin/get"; connection_timeout=5, retry=false, socket_type_tls=Sockets.TCPSocket)
HTTP.get("https://$httpbin/get"; connect_timeout=5, retry=false, socket_type_tls=Sockets.TCPSocket)
@test true # if we get here, we didn't timeout
finally
HTTP.set_default_connection_limit!(connection_limit)
Expand Down

0 comments on commit f9389ae

Please sign in to comment.