Proxy support for HTTPS connection pool #1050
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustafsson
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1050 +/- ##
==========================================
+ Coverage 82.71% 83.26% +0.55%
==========================================
Files 32 33 +1
Lines 3054 3066 +12
==========================================
+ Hits 2526 2553 +27
+ Misses 528 513 -15 ☔ View full report in Codecov by Sentry. |
gustafsson
force-pushed
the
pools-with-proxy
branch
4 times, most recently
from
95e344f
to
aefc458
Compare
gustafsson
changed the title
gustafsson
force-pushed
the
pools-with-proxy
branch
from
aefc458
to
0753db1
Compare
Creates a tunneled connection with a pool key that `aquire` can find on subsequent requests if the connection is kept alive
gustafsson
force-pushed
the
pools-with-proxy
branch
from
0753db1
to
044874a
Compare
|
(I've rebased since this PR was created a while ago) This PR currently consists of 3 commits:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection pools are really effective. This PR makes them work through a proxy as well.
When establishing an HTTPS connection through a proxy a connection is first made with the proxy and then a second connection, a tunnel, is established with the target host. This second connection is kept in a pool whereas the connection with the proxy is not kept in the pool.
Later, when a subsequent connection is made with the same target host it could reuse the tunnel. Unfortunately the tunnel isn't found when looking in the pool for available connections. The reason is that the
sslupgradefunction creates a newConnectionwith a differentconnectionkey. This mismatch between keys causesnewconnectionto not find the reusable tunnel connection, even though we readily keep the tunnel alive sitting there just waiting to be reused.In this PR,
newtunnelconnectionuses aconnectionkeythat can be reused as expected.Does this look like the right approach for this kind of functionality?