Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readbytes! to avoid using internal API of IOBuffer less #1148

Merged
merged 6 commits into from
Mar 5, 2024

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Feb 14, 2024

Note that this claims to be supported for all GenericIOBuffer, but Base only defines this function on a normal IOBuffer for which pointer(data) is contiguous space

Note that this claims to be supported for all GenericIOBuffer, but Base only defines this function on a normal IOBuffer for which `pointer(data)` is contiguous space
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.62%. Comparing base (040cf0a) to head (6f3353f).

Files Patch % Lines
src/Streams.jl 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1148      +/-   ##
==========================================
- Coverage   82.67%   82.62%   -0.05%     
==========================================
  Files          32       32              
  Lines        3054     3051       -3     
==========================================
- Hits         2525     2521       -4     
- Misses        529      530       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vtjnash
Copy link
Member Author

vtjnash commented Feb 23, 2024

Alright, I think I fixed the remaining test issues so this is passing on all versions now

@vtjnash vtjnash requested a review from quinnj February 24, 2024 00:27
@oscardssmith
Copy link

bumping this.

@quinnj quinnj merged commit e27493d into master Mar 5, 2024
11 checks passed
@quinnj quinnj deleted the jn/readbytes-internals branch March 5, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants